Skip to content

fix(chat-app): accept trace message deep link - #158

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-157-chat-trace-link
May 26, 2026
Merged

fix(chat-app): accept trace message deep link#158
rowan-stein merged 2 commits into
mainfrom
noa/issue-157-chat-trace-link

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Update chat trace-link E2E to accept the tracing /message/<messageId>?orgId=<orgId> deep-link page.
  • If tracing redirects to the run page, keep validating run-summary-status, run events, message content, and LLM output.
  • If tracing stays on the message deep-link page, validate the message-page status UI instead of requiring run-page widgets.

Fixes #157

Validation

  • cd suites/playwright-chat-app && npx buf generate && npx tsc --noEmit — passed
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts — 2 passed, 0 failed, 0 skipped
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-api.spec.ts — 4 passed, 0 failed, 0 skipped
  • git diff --check — passed with no errors

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Validation Summary

  • cd suites/playwright-chat-app && npx buf generate && npx tsc --noEmit: passed with no errors
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts: 2 passed, 0 failed, 0 skipped
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-api.spec.ts: 4 passed, 0 failed, 0 skipped
  • git diff --check: passed with no errors

Comment thread suites/playwright-chat-app/test/e2e/chat-trace-link.spec.ts Outdated

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused fix. I left one blocking comment: the new message-page branch can pass on a transient loading state before the deep link has had enough time to resolve to the run page. Please tighten that assertion so this E2E still catches message-to-run resolution regressions.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Validation Summary

  • cd suites/playwright-chat-app && npx tsc --noEmit: passed with no errors
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-api.spec.ts: 4 passed, 0 failed, 0 skipped
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts: 0 passed, 2 failed, 0 skipped locally because current https://tracing.agyn.dev did not resolve created chat message deep links to run pages within 180s; this confirms the tightened test no longer passes on the transient waiting state.
  • git diff --check: passed with no errors

Updated the PR so the chat trace-link test now waits for a stable run page and validates run widgets/events. It no longer returns successfully from Waiting for run to appear; if the deep link remains unresolved, it fails with the current URL.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

CI is green after the update.

Final Validation Summary

  • cd suites/playwright-chat-app && npx tsc --noEmit: passed with no errors
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-api.spec.ts: 4 passed, 0 failed, 0 skipped
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts: 0 passed, 2 failed, 0 skipped locally because current https://tracing.agyn.dev did not resolve created chat message deep links to run pages within 180s; this confirms the tightened test no longer passes on the transient waiting state.
  • git diff --check: passed with no errors
  • GitHub Actions E2E for PR fix(chat-app): accept trace message deep link #158: passed

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the update. The transient message-page pass branch has been removed, the helper now requires eventual run-page resolution while allowing the retry path, and the existing run-page assertions remain intact. TypeScript validation passes locally after generating buf sources, and CI is green.

@rowan-stein
rowan-stein merged commit 1b44227 into main May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playwright-chat-app: trace link test should follow message deep link to run page (run-summary-status missing)

3 participants