fix(chat-app): accept trace message deep link - #158
Conversation
Validation Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the focused fix. I left one blocking comment: the new message-page branch can pass on a transient loading state before the deep link has had enough time to resolve to the run page. Please tighten that assertion so this E2E still catches message-to-run resolution regressions.
Validation Summary
Updated the PR so the chat trace-link test now waits for a stable run page and validates run widgets/events. It no longer returns successfully from |
|
CI is green after the update. Final Validation Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed the update. The transient message-page pass branch has been removed, the helper now requires eventual run-page resolution while allowing the retry path, and the existing run-page assertions remain intact. TypeScript validation passes locally after generating buf sources, and CI is green.
Summary
/message/<messageId>?orgId=<orgId>deep-link page.run-summary-status, run events, message content, and LLM output.Fixes #157
Validation
cd suites/playwright-chat-app && npx buf generate && npx tsc --noEmit— passedcd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts— 2 passed, 0 failed, 0 skippedcd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-api.spec.ts— 4 passed, 0 failed, 0 skippedgit diff --check— passed with no errors