Repository navigation
docs: Improve Japanese and Simplified Chinese documentation - #280
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d88830b8e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 3. 拒否するには**pypi**を選択し理由を添えて**Reject**を選びます。期待した停止や制御がなければアップロード前に中止・キャンセルします。拒否/キャンセル実行を保持して原因を解決します。拒否回避のためタグを移動したり版を再利用しません。 | ||
| 4. 担当、判断、コメント、時刻と結果を記録し、アップロード/検証証拠を保持します。拒否は公開成功や承認停止検証成功ではありません。管理者迂回は例外で別途明示的な所有者承認が必要で、理由、実行者、時刻、実行、タグ、コミットを記録します。 | ||
| 1. アップロード前に、対象のActions実行がpypiのレビュー待ちで停止していることを確認します。実行URL/ID、試行回数、タグ、コミット、SHA256SUMS、release-provenance.json、保留時刻を記録します。ソーステストやリポジトリ設定だけでは停止を証明できません。次回リリースで実際の停止を確認することが#235の受け入れ条件です。 | ||
| 2. 必須の人手レビュー担当者が候補の証拠と現在のTrusted Publisher/環境設定を確認します。**Review deployments**で**pypi**を選び、承認権限がある場合に限り**Approve and deploy**を明示的に選択します。GitHub公開の承認は、このレビューの代わりにはなりません。デプロイが保留になったら必須の人手レビューを依頼し、環境ゲートを維持します。 |
There was a problem hiding this comment.
For a reviewer using the Japanese runbook, 承認権限がある場合 means “when the reviewer has approval permission,” rather than the canonical requirement to choose Approve and deploy only when this deployment is authorized. Since every required environment reviewer necessarily has that permission, this wording can direct them to approve a pending PyPI upload even when release authorization is absent; retain the distinction by saying that approval is allowed only after authorization has been obtained.
Useful? React with 👍 / 👎.
| ## 历史证据与当前边界 | ||
|
|
||
| 五主机v1.0.0 RC4 rc4-rerun-02测试运行14,436.65秒：complete记录、公开健康241/241、探测147/147、提交21/21及Relay重启恢复3.182秒。独立ACK为20/21。T120 Windows原生Claude因TUI关闭未确认原始ACK，另一次单独测试收到准确ACK。所有者在#164接受此例外。保留20/21；历史证据不验证v1.0.4。#161的外部停滞根因仍未确认。 | ||
| 在5台主机上进行的v1.0.0 RC4 rc4-rerun-02测试持续了14,436.65秒。记录状态为complete，公开健康检查为241/241，探测为147/147，提交为21/21，Relay重启后的恢复时间为3.182秒。独立确认的ACK为20/21。T120时Windows原生Claude的TUI已关闭，因此原始ACK未能确认；之后另一次单独测试收到了准确的ACK。所有者在#164中接受了这一例外。请保留20/21这一结果；这段历史记录不能证明v1.0.4已通过验证。#161仍未解决，外部停滞的根本原因也尚未确认。 |
There was a problem hiding this comment.
In this evidence record, T120 is the identifier of the Windows-native Claude test, as also preserved in docs/zh-CN/releases/v1.0.0.md; adding 时 makes the sentence read “at T120” and turns it into a time reference. This obscures which specific test produced the unconfirmed ACK when operators correlate the exception with #164, so keep T120 as an unmodified label.
Useful? React with 👍 / 👎.
| 3. 确认PyPI尚无1.0.4文件。2026-10-07准备检查中，该版本JSON返回HTTP 404。检查GitHub Immutable Releases及v*标签规则：允许创建，禁止无绕过的标签修改/删除。所有者于2026-10-03启用 (规则24408525)，2026-10-05检查确认严格main发布门禁。2026-10-07 GitHub API检查再次确认Immutable Releases启用、规则24408525有效、范围refs/tags/v*、无绕过的更新/删除禁令。历史v1.0.2为非不可变且无资产，不是已验证单文件发布；发布前重新检查当前配置。 | ||
| 4. 确认Trusted Publisher将session-peer映射到abruption/session-peer、publish.yml和pypi。2026-10-05通过已登录PyPI浏览器验证该映射；这是历史证据，不是新的PyPI浏览器复验。2026-10-07 GitHub API检查再次确认要求审核者`abruption`、允许自审 (`prevent_self_review: false`) 及`v*`标签。2026-10-05检查时管理员绕过启用 (`can_admins_bypass: true`)；不要把该历史观察当作新的绕过策略检查。所有者此前的[2026-09-29映射检查](https://github.com/abruption/session-peer/issues/235#issuecomment-5882178667)也是历史证据。重新检查配置，使用正常人工审核，不得静默绕过。 | ||
| 1. 将v1.0.4的变更与v1.0.3及四种语言的发布说明对照。确保合并后的main包含#262、#263、#264、#265、#266、#267这6项维护修复。保留已发布的v1.0.3安全历史，以及独立技能的版本、最低运行时版本和完整功能覆盖版本契约。确认软件包和生成文件中的版本、四种语言README中的稳定版提示，以及归档内的发布说明。冻结cc_peer.py并将其排除在发行包之外；同时排除凭据、密钥、数据库、重放状态、浏览器配置文件、本地证据和聊天记录。 | ||
| 2. 运行完整的本地测试和PR发布门禁。合并后，必须确认合并后的公开main在准确提交上通过CI。私有安全公告修复分支上的检查不能替代公开发布门禁。验证在干净环境中安装wheel/sdist、在隔离环境中导入已安装的软件包、CLI版本准确、在已初始化主目录中执行JSON list、extras以及pip check。显式指定的空Codex主目录必须以state_db_missing安全失败（fail closed）。此门禁不发送真实消息。 |
There was a problem hiding this comment.
For an operator following the Chinese release procedure, the canonical text explicitly says not to submit live messages during this gate, and the previous translation likewise used the imperative 不要发送实时消息. The replacement instead asserts that the gate itself does not send real messages, so it no longer prohibits an operator from adding a manual live-message check and can misleadingly describe customized gate execution; preserve the imperative instruction here.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
추가 반영: |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
abruption
changed the title
48802a4 to
c4e75e2
Compare
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Closes #279
Summary
README.ja.mdandREADME.zh-CN.md, closing the wrapper before the body.Read-only translation-assistance review
claude-opus-5-5: the first review covered only the six README/RELEASING/SECURITY files, did not read the Korean references, and did not locate the plugin guide. A follow-up read-only review was given the exact paths and checked the English sources and both localized plugin guides.Validation
python3 -m unittest discover -s tests/docs -v: 31 tests passed.git diff --check: passed.No English documents, runtime code, tests, release or package artifacts, or operational settings were changed. This PR is open for review; it has not been merged, tagged, released, or published.