Repository navigation
feat(claude): discover bounded Orca profiles with provenance checks - #173
Conversation
Preserve registry provenance through selection and handoff checks, and refuse incomplete or conflicting inventories before submission. Refs #165
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e475f631f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…robes Require current-user ownership and non-writable-by-others automatic directory and record evidence, including canonical aliases. Treat known-invalid PID 1 as stale before Windows inspection. Refs #165
…le processes Distinguish confirmed Windows process absence from unknown inspection, and retain metadata for all observed registration and endpoint paths through the last effect boundary. Refs #165
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
There was a problem hiding this comment.
🛡️ Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: d7997b520a
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Inspect automatic directories and records through bounded trusted macOS metadata batches and revalidate ACL/path evidence before effect. Preserve legacy explicit and default-only behavior. Refs #165
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Problem and resulting behavior
Claude sessions registered only in macOS Orca profiles are missing from the default list and target-selection path. This change inventories the default registry and known immediate Orca profile locations, carrying the selected registration source through send and handoff checks instead of reconstructing a default path.
CLAUDE_CONFIG_DIR/ANTHROPIC_CONFIG_DIRoverrides retain precedence and isolate discovery to one registry. Linux and Windows do not scan the macOS convention.Validation
Exact head
3373c265b2ba240106ca152fed190fa74543658don Node 24.22.1 / macOS arm64:8ca77cf31254c8287a2593fe484bb30a7dba2727.git diff --checkpass.Independent Codex review findings were checked against source and fixed with regression fixtures. The two GitHub review threads (confirmed Windows absence; all-record final fencing) have fixes and replies in
d7997b5and are resolved. The existing name-ambiguity fixture now uses distinct endpoints so it continues testing name ambiguity rather than conflicting endpoint claims. Initial Windows CI also exposed PID 1 being treated as an inspection failure; known-invalid PIDs are now rejected before native inspection, without weakening actual failure handling.Current-head CI is 12/12 successful (macOS/Ubuntu Node 22/24, Windows Node 22/24, repository policy, package/release gate, CodeQL and GitGuardian). Fresh manual Code Review and Security Review both completed on this exact head with no findings.
No actual user profile inventory, real agent inbox input, live native/model/SSH or ACK qualification was performed. Test sockets/processes are isolated fixtures. No merge, release, npm publication or global installation is included.
Closes #165