Repository navigation
(release/25.2) ci(workflows): retry the DragonFlyBSD VM step on transient boot flakes - #3938
Merged
Merged
Conversation
The DragonFlyBSD lane runs the vmactions VM step exactly once. When the VM
fails to boot/provision transiently ("ssh: Could not resolve hostname
dragonflybsd"), the lane is red and nothing retries it. Add a 3-attempt
retry with continue-on-error on attempts 1-2; each attempt uses its own
guest name so a leftover domain from a failed boot does not collide with
the next attempt.
The retry `if:` uses !cancelled() instead of the implicit success() status
function - after attempt 1 fails, success() is false and would silently
skip the later attempts.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry der DragonFlyBSD-VM-Lane bei transientem Boot-Flake.
xserver-build-dragonflybsdführte den vmactions-VM-Step exakt einmal aus.Bootet die VM transient nicht hoch ("ssh: Could not resolve hostname
dragonflybsd"), ist die Lane rot und nichts retriert. Das ist ein reines
Infra-Problem (VM-Image/Boot), kein Code-Defekt.
Änderung: 3-Versuche-Retry mit
continue-on-errorauf Attempt 1+2; jederAttempt nutzt einen eigenen
guest-Namen, damit ein von einem fehlgeschlagenenBoot hinterlassenes Domain nicht mit dem nächsten Attempt kollidiert
("Guest name ... is already in use") — auf diesem Zweig gibt es keine
libvirt-cleanup-Action, daher die Kollisionsvermeidung über die Namen.Wichtig: Die Retry-
if:-Bedingungen nutzen!cancelled()statt derimpliziten
success()-Statusfunktion — nach demcontinue-on-error-Fehlschlagvon Attempt 1 ist
success()false und würde die späteren Attempts stillüberspringen (derselbe Fehler wie #3937 auf master).
Kein Code-/Build-Verhalten geändert — nur die Lane-Robustheit.