Repository navigation
Conversation
This was referenced Oct 13, 2026
metux
force-pushed
the
wt/dfly-retry-fix
branch
3 times, most recently
from
October 14, 2026 11:21
02d4ce9 to
ac339fc
Compare
The retry `if:` conditions (steps.<x>-1.outcome == 'failure') rely on the
implicit success() status function. After attempt 1 fails with
continue-on-error, success() is false, so every later step — the stale-VM
cleanup and attempts 2/3 — is silently skipped. Observed on
xserver-build-dragonflybsd: the VM fails to boot ("ssh: Could not resolve
hostname dragonflybsd"), the single attempt is red, and the lane never
recovers because the retry chain never fires.
Prefix the retry conditions with !cancelled() (true whenever the workflow
isn't cancelled, regardless of the earlier continue-on-error failure) so a
transient VM boot/image flake is retried up to 3x. Applied to the identical
dragonflybsd, freebsd and netbsd retry chains.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
wt/dfly-retry-fix
branch
from
October 19, 2026 11:07
ac339fc to
e46b1ce
Compare
metux
force-pushed
the
master
branch
5 times, most recently
from
October 30, 2026 11:57
eae2c21 to
483a172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Die VM-Retry-Ketten (
dragonflybsd,freebsd,netbsd) feuern nie, weil dieRetry-
if:-Bedingungen auf der implizitensuccess()-Statusfunktion beruhen:Nach einem
continue-on-error-Fehlschlag von Attempt 1 istsuccess()false → allespäteren Steps (Stale-VM-Cleanup und Attempts 2/3) werden stillschweigend übersprungen.
Beobachtet auf
xserver-build-dragonflybsd: Die VM bootet transient nicht hoch(
ssh: Could not resolve hostname dragonflybsd), der eine Versuch ist rot, und die Laneerholt sich nie, weil die Retry-Kette nie ausgelöst wird.
Fix
Die Retry-
if:-Bedingungen mit!cancelled()präfixieren — das ist true bei jedemnicht-abgebrochenen Lauf, unabhängig vom früheren
continue-on-error-Fehlschlag. Damit wirdein transienter VM-Boot-/Image-Flake bis zu 3× wiederholt.
Angewendet auf die identischen Ketten von
dragonflybsd,freebsdundnetbsd(jeweilsCleanup vor Retry + 3 Versuche). Ein erklärender Kommentar bei der DragonFly-Kette
dokumentiert die
success()-Falle.Kein Verhaltens-Change am Build selbst — nur die Retry-Auslösung.