Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Update shape of theme.json: settings & styles as top-level keys - #175

Merged
carolinan merged 3 commits into
WordPress:masterfrom
oandregal:try/new-shape
Feb 1, 2021
Merged

carolinan merged 3 commits into
WordPress:masterfrom
oandregal:try/new-shape

Conversation

@oandregal

@oandregal oandregal commented Jan 22, 2021 •

Copy link
Copy Markdown
Member

📢 The changes have landed in Gutenberg master, so this is ready

The goal of this PR is to serve as a testbed for the upcoming changes at WordPress/gutenberg#28110

@oandregal

Copy link
Copy Markdown
Member Author

WordPress/gutenberg#28110 is ready and will be merged soon (probably tomorrow). Should this PR be merged soon after so this repo is in sync with Gutenberg's main branch?

cc @kjellr @scruffian

@carolinan

Copy link
Copy Markdown
Contributor

If we do that, the documentation must be updated to reflect that this version of the theme requires the development version of Gutenberg.

It needs to be made very clear to users, including those who are testing FSE within the FSE outreach program, which version of the theme to use for testing, together with which version of Gutenberg.

@oandregal

Copy link
Copy Markdown
Member Author

Updated this to make it work with WordPress/gutenberg#28533

@oandregal

Copy link
Copy Markdown
Member Author

I figured this PR could be useful for people to match the changes in WordPress/gutenberg#28110 given that it has landed in master so I scoped it down to it.

Not sure how's the process but this can land safely.

There's now a separate #182 to serve a testbed for a new Gutenberg PR.

@oandregal oandregal changed the title Update shape of theme.json (do not merge yet) Update shape of theme.json: settings & styles as top-level keys Jan 28, 2021
@kjellr

kjellr commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

My suggestion is that we merge this in to the version here (alongside a version bump), but do not upload this version to the theme repository until it's been merged into the plugin.

I do think some sort of clarifying note in this repo may be helpful — something along the lines of "The version of the theme in this repository may rely on Gutenberg features that have not yet made it into an official release."

@oandregal

oandregal commented Jan 28, 2021 •

Copy link
Copy Markdown
Member Author

I wanted to share that the second PR to update the theme.json shape also landed in Gutenberg and will be part of 9.9 WordPress/gutenberg#28533 This will still require the plugin to work and won't be part of WordPress 5.7.

Given that the two Gutenberg PRs already landed I think it's best to close this PR and land #182 instead (it has all the changes already).

@oandregal oandregal mentioned this pull request Jan 29, 2021
@carolinan
carolinan merged commit 98234e4 into WordPress:master Feb 1, 2021
@oandregal
oandregal deleted the try/new-shape branch February 1, 2021 11:28
@oandregal oandregal mentioned this pull request Feb 3, 2021
75 of 82 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants