Repository navigation
wp-now: Mount the parent theme when running in a child theme - #58
Merged
Merged
Conversation
danielbachhuber
approved these changes
Jun 6, 2023
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
Works as expected with one tweak: a479df3
I downloaded https://wordpress.org/themes/moina-blog/, unzipped it, and ran nx preview wp-now start --path=/Users/danielbachhuber/projects/playground-test/child-theme/moina-blog. It was marked as a broken theme because it was missing its parent:
When I downloaded the parent theme (https://wordpress.org/themes/moina/) and unzipped it in the same directory, the child theme activated as expected:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pr introduces a fix when the user works in a child theme. In this case, the parent theme is not mounted and this creates a "Missing parent theme" error:

Why?
This pr is the first attempt to fix that error.
There is plenty of discussion about this problem here
How?
As a first step to solve this issue, we try to find the parent theme and mount it in the appropriate folder.
We assume that the parent theme is available in the parent directory, and there is some upcoming work to handle more complex scenarios
Testing Instructions
wp-now start --path=<your-child-theme-path>/wp-admin/themes.phpand ensure that you: