You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Local Environment: Child theme can't be activated #33
Noting here that WordPress also fails if the parent theme is missing. If we can mirror WordPress behavior that seems sufficient. If WordPress can auto-install then that seems reasonable, but for many themes we know this is impossible because they don't exist in the registry.
For those cases it seems sufficient to scope-limit this tool to not solve problems WordPress itself doesn't solve.
Activity
sejas commentedon May 15, 2023
@katinthehatsite, Do you want to take this one?
katinthehatsite commentedon May 15, 2023
let's do this - or at least attempt 😅
danielbachhuber commentedon May 18, 2023
@katinthehatsite I'm going to pick this up so you can focus on your upcoming project.
danielbachhuber commentedon May 18, 2023
With some more reflection, I actually want to hold off on fixing this for now:
I'd love to hear more reports from folks who run into this in the wild, and what their scenario is.
cpapazoglou commentedon May 19, 2023
If it doesn't exist locally and if it's a .org theme, yes, it would be nice!
dmsnell commentedon May 19, 2023
Noting here that WordPress also fails if the parent theme is missing. If we can mirror WordPress behavior that seems sufficient. If WordPress can auto-install then that seems reasonable, but for many themes we know this is impossible because they don't exist in the registry.
For those cases it seems sufficient to scope-limit this tool to not solve problems WordPress itself doesn't solve.
danielbachhuber commentedon May 19, 2023
I'm also not sure if we can know definitively that a given theme is a WordPress.org theme.
cpapazoglou commentedon May 19, 2023
3pd themes usually don't have a slug used in .org. For example
https://api.wordpress.org/themes/info/1.1/?action=theme_information&request%5Bslug%5D=astrareturns data forastratheme.wojtekn commentedon May 19, 2023
I agree with @dmsnell , local environment tool shouldn't solve WordPress problems that way.
Activating the parent theme would be enough, assuming we use 'wp-content' mode with both themes available or we have support for paths mapping.
danielbachhuber commentedon Jun 1, 2023
This came up again with #39
For now, let's mount the parent theme directory too if it sits alongside the child theme. More complex configurations can be handled with #19
wp-now: Mount the parent theme when running in a child theme (#58)
Setup eslint and prettier (WordPress#33)