You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IE11: Only fire hide if focus is transferring outside of the div - #3416
The onBlur was firing on IE 11, even though the focus was shifting inside the div. That was firing hide which meant that the focused button disappeared, and focus reverted to the body.
How Has This Been Tested?
Manually
I needed to do the changes from #3415 as well. But I'm not sure if anyone else is experiencing that problem, so I might have just missed a fix somewhere.
As discussed in the issue, if this isn't good enough, we may need to use the withFocusOutside HOC again. However, cursory browser testing seemed promising.
ephox-mogran
changed the title
IE11: Only fire hide is focus is transferring outside of the div
IE11: Only fire hide if focus is transferring outside of the div
Nov 10, 2017
More just that in implementation it introduces a setTimeout. If we were able to implement it without that and without a global listener (if not using a setTimeout), then no problem at all with it being the best solution. Do you disagree?
More just that in implementation it introduces a setTimeout.
If we treat it in the abstract, we shouldn't necessarily be concerned by this, and we're able to refactor later if need be. Timeouts are an issue, yes, but mostly in being properly implemented. If we can assume that withFocusOutside is well-implemented, then it shouldn't be cause for much alarm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: #3408
The
onBlurwas firing on IE 11, even though the focus was shifting inside the div. That was firinghidewhich meant that the focused button disappeared, and focus reverted to the body.How Has This Been Tested?
Manually
I needed to do the changes from #3415 as well. But I'm not sure if anyone else is experiencing that problem, so I might have just missed a fix somewhere.