Skip to content

IE11: Only fire hide if focus is transferring outside of the div - #3416

Closed
ephox-mogran wants to merge 1 commit into
masterfrom
fix/sibling-inserter-keyboard-nav
Closed

ephox-mogran wants to merge 1 commit into
masterfrom
fix/sibling-inserter-keyboard-nav

Conversation

@ephox-mogran

Copy link
Copy Markdown
Contributor

Description

Fix: #3408

The onBlur was firing on IE 11, even though the focus was shifting inside the div. That was firing hide which meant that the focused button disappeared, and focus reverted to the body.

How Has This Been Tested?

Manually

I needed to do the changes from #3415 as well. But I'm not sure if anyone else is experiencing that problem, so I might have just missed a fix somewhere.

@ephox-mogran
ephox-mogran requested a review from aduth November 10, 2017 01:56
@ephox-mogran

Copy link
Copy Markdown
Contributor Author

As discussed in the issue, if this isn't good enough, we may need to use the withFocusOutside HOC again. However, cursory browser testing seemed promising.

@codecov

codecov Bot commented Nov 10, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3416 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3416      +/-   ##
==========================================
- Coverage   31.98%   31.96%   -0.02%     
==========================================
  Files         249      249              
  Lines        6901     6904       +3     
  Branches     1254     1255       +1     
==========================================
  Hits         2207     2207              
- Misses       3945     3947       +2     
- Partials      749      750       +1
Impacted Files Coverage Δ
editor/modes/visual-editor/sibling-inserter.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f8169...185e08b. Read the comment docs.

@ephox-mogran ephox-mogran changed the title IE11: Only fire hide is focus is transferring outside of the div IE11: Only fire hide if focus is transferring outside of the div Nov 10, 2017
@aduth

aduth commented Nov 13, 2017

Copy link
Copy Markdown
Member

we may need to use the withFocusOutside HOC again

Is there a reluctance to using this as the ideal solution?

@ephox-mogran

Copy link
Copy Markdown
Contributor Author

More just that in implementation it introduces a setTimeout. If we were able to implement it without that and without a global listener (if not using a setTimeout), then no problem at all with it being the best solution. Do you disagree?

@aduth

aduth commented Nov 14, 2017

Copy link
Copy Markdown
Member

More just that in implementation it introduces a setTimeout.

If we treat it in the abstract, we shouldn't necessarily be concerned by this, and we're able to refactor later if need be. Timeouts are an issue, yes, but mostly in being properly implemented. If we can assume that withFocusOutside is well-implemented, then it shouldn't be cause for much alarm.

@aduth

aduth commented Nov 14, 2017

Copy link
Copy Markdown
Member

See also #3408 (comment)

@youknowriad

youknowriad commented Feb 2, 2018 •

Copy link
Copy Markdown
Contributor

The sibling inserter has been removed, I'm closing. We can reopen if we restore it later.

@youknowriad youknowriad closed this Feb 2, 2018
@gziolo
gziolo deleted the fix/sibling-inserter-keyboard-nav branch May 7, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IE 11: sibling inserter doesn't appear, breaking keyboard navigation

3 participants