Skip to content

FIX: use lodash version of startsWith because IE does not support startsWith natively - #3415

Merged
ephox-mogran merged 1 commit into
masterfrom
fix/use-lodash-startsWith-for-ie
Nov 10, 2017
Merged

ephox-mogran merged 1 commit into
masterfrom
fix/use-lodash-startsWith-for-ie

Conversation

@ephox-mogran

Copy link
Copy Markdown
Contributor

Description

Fixes #3414

Use lodash's startsWith implementation. IE does not support startsWith

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith

How Has This Been Tested?

Manually.

Types of changes

Bug fix.

@ephox-mogran
ephox-mogran requested a review from aduth November 9, 2017 22:50
@codecov

codecov Bot commented Nov 9, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #3415 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3415   +/-   ##
=======================================
  Coverage   31.98%   31.98%           
=======================================
  Files         249      249           
  Lines        6901     6901           
  Branches     1254     1254           
=======================================
  Hits         2207     2207           
  Misses       3945     3945           
  Partials      749      749
Impacted Files Coverage Δ
blocks/api/serializer.js 98.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f8169...8b0f768. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IE11: Clicking in Write Your Story breaks Gutenberg

2 participants