You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Embed Block: How to select the block without starting video #483
The Embed block (#316) appears to work well up until a video is actually embedded, at which point it looks as though clicking the block will start it playing. Even though that won't be the case (we should port the click interceptor that's in WordPress now), the UI observation still stands.
What's a good approach to make this interface less obtuse, so we don't frighten users from clicking the block? Let's discuss. Some ideas:
Abstract live preview for the block — don't show 1:1 what it will look like, perhaps include a generic border with meta information
Add a clickable UI fixture permanently docked near the embed
@iseulde brought up an excellent point about fixtures that show up on hover - how do we handle that on mobile? This is especially important as it's on mobile that users are least likely to click a video because they expect youtube apps to pop up and to be charged for data used playing the video.
My preference would be for the abstract preview, perhaps with an option to toggle and see the "live" content? (but I'm not a designer, just a pretty good new-user-simulator 😄 )
My preference would be for the abstract preview, perhaps with an option to toggle and see the "live" content? (but I'm not a designer, just a pretty good new-user-simulator 😄 )
I lean towards this as well. It's a stellar argument for why abstract live preview has benefits, over 1:1 100% live preview.
By "abstract live preview" I mean a block design that clearly indicates that this is a video that's embedded, and it suggests what the end result will look like, without being a 100% 1:1 preview.
Take the [gallery] block in the current editor, that's an abstract preview. It's arguably too abstract, but it's the same vein as what I mean.
a block design that clearly indicates that this is a video that's embedded, and it suggests what the end result will look like, without being a 100% 1:1 preview.
A solution could be something like the following:
Another alternative could be:
A UI element that appears with or without hovering - for mobile users it indicates itself as a block that can be moved around without worry of playing the video. Just brainstorming ideas, please let me know if I am off-base here, as I could be misunderstanding the problem.
This is not a feature that has to be part of the shipping version, but it's definitely something that would enhance the experience. I struggle with selecting embedded videos every time.
This is also related to selection of embeds generally, not just videos. Notably, selecting any embed block (say, a Twitter block) recently regressed to not being possible in #4872 (previously fixed in #4011).
The idea of showing an overlay could work just as well for non-video in helping to make the blocks selectable. Open questions are:
Would it have the same background color?
Would it include the label for embed type? (Twitter is "rich")
Alternatively, we can restore the intended behaviors of #4011, but this would require reintroducing a prop for blocks to programmatically call to select themselves (e.g. setSelected).
Would it include the label for embed type? (Twitter is "rich")
I'd say it should be the name title of the block instead of the type. There are cases where oembed is overridden and we don't get type information at all, so how we handle type information in the embed blocks is going to change at some point (I'm working on this now). To make this properly useful, we'd need to switch to the right block based on the URL, and I'm working on that too.
The embed block seems to now work without the video playing. I just tested this using a YouTube video. I am closing, if this is not fixed we can always reopen.
Reopening this issue as the problem is present again, and being worked on in #12981. This ticket has a lot of discussion, including mockups, so it's worth resurfacing these to keep things collected.
Activity
notnownikki commentedon Apr 24, 2017
@iseulde brought up an excellent point about fixtures that show up on hover - how do we handle that on mobile? This is especially important as it's on mobile that users are least likely to click a video because they expect youtube apps to pop up and to be charged for data used playing the video.
My preference would be for the abstract preview, perhaps with an option to toggle and see the "live" content? (but I'm not a designer, just a pretty good new-user-simulator 😄 )
jasmussen commentedon Apr 24, 2017
I lean towards this as well. It's a stellar argument for why abstract live preview has benefits, over 1:1 100% live preview.
ellatrix commentedon Apr 24, 2017
What would an "abstract preview" look like? How to make it?
jasmussen commentedon Apr 24, 2017
By "abstract live preview" I mean a block design that clearly indicates that this is a video that's embedded, and it suggests what the end result will look like, without being a 100% 1:1 preview.
Take the
[gallery]block in the current editor, that's an abstract preview. It's arguably too abstract, but it's the same vein as what I mean.rileybrook commentedon Apr 26, 2017
If I understand @jasmussen correctly:
A solution could be something like the following:


Another alternative could be:
A UI element that appears with or without hovering - for mobile users it indicates itself as a block that can be moved around without worry of playing the video. Just brainstorming ideas, please let me know if I am off-base here, as I could be misunderstanding the problem.
jasmussen commentedon Apr 26, 2017
That's solid work @rileybrook, and aside from a few stylistic tweaks, pretty much exactly what I meant.
Inspired by Riley I took it a step further:
notnownikki commentedon Apr 26, 2017
Wow, fading out the video and showing the caption placeholder changes the feel of it completely! There's no doubt that I'm in editing mode there.
👍 from me!
mtias commentedon Feb 6, 2018
@jasmussen do we still want to do this?
jasmussen commentedon Feb 6, 2018
This is not a feature that has to be part of the shipping version, but it's definitely something that would enhance the experience. I struggle with selecting embedded videos every time.
1 remaining item
aduth commentedon Feb 27, 2018
This is also related to selection of embeds generally, not just videos. Notably, selecting any embed block (say, a Twitter block) recently regressed to not being possible in #4872 (previously fixed in #4011).
The idea of showing an overlay could work just as well for non-video in helping to make the blocks selectable. Open questions are:
Alternatively, we can restore the intended behaviors of #4011, but this would require reintroducing a prop for blocks to programmatically call to select themselves (e.g.
setSelected).notnownikki commentedon Feb 27, 2018
I'd say it should be the
nametitle of the block instead of the type. There are cases where oembed is overridden and we don't get type information at all, so how we handle type information in the embed blocks is going to change at some point (I'm working on this now). To make this properly useful, we'd need to switch to the right block based on the URL, and I'm working on that too.aduth commentedon Apr 13, 2018
Embed blocks can now be easily selected again as of #5730.
karmatosed commentedon May 19, 2018
The embed block seems to now work without the video playing. I just tested this using a YouTube video. I am closing, if this is not fixed we can always reopen.
jasmussen commentedon Dec 20, 2018
Reopening this issue as the problem is present again, and being worked on in #12981. This ticket has a lot of discussion, including mockups, so it's worth resurfacing these to keep things collected.
youknowriad commentedon Feb 11, 2019
closed by #12981