You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jasmussen thoughts on caption there? I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.
I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.
So long as I can make a linebreak, center and italicize some text, I don't have strong opinion.
I think in general, it makes sense for media items, but if you embed something and the resulting block is something non media related, yeah probably would feel weird with a caption.
In the case of oEmbed, this could still be the link to the resource. It's valid to store it in a figure, and it comes with some handy things like floating.
I think you both make really solid arguments here.
Can we "wait and see what feels right" on this one? Or are there other ways we can get closer to a consensus? Do we have a list of all supported oembeds? Maybe we can look at the list and see if a whole bunch of them would look super weird with captions, and decide from that.
Maybe I am just a bit lazy, but I cannot see option to insert/embed video from local server ?
I mean upload to Media Library, and chose it same way as image/gallery.
Activity
aduth commentedon Apr 21, 2017
What's the markup of an embed block which has a caption assigned?
mtias commentedon Apr 26, 2017
@jasmussen thoughts on caption there? I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.
ellatrix commentedon Apr 26, 2017
Why would it not?
jasmussen commentedon Apr 26, 2017
So long as I can make a linebreak, center and italicize some text, I don't have strong opinion.
I think in general, it makes sense for media items, but if you embed something and the resulting block is something non media related, yeah probably would feel weird with a caption.
mtias commentedon Apr 26, 2017
Yes, that's my hesitance, it'd feel spurious in some embeds and adds some visual and cognitive weight.
ellatrix commentedon Apr 26, 2017
Somehow, I do like that all "object blocks" would have the same markup and caption support.
Whether it's an image, gallery, embed, table, or other form of data visualisation.
ellatrix commentedon Apr 26, 2017
In the case of oEmbed, this could still be the link to the resource. It's valid to store it in a figure, and it comes with some handy things like floating.
jasmussen commentedon Apr 27, 2017
I think you both make really solid arguments here.
Can we "wait and see what feels right" on this one? Or are there other ways we can get closer to a consensus? Do we have a list of all supported oembeds? Maybe we can look at the list and see if a whole bunch of them would look super weird with captions, and decide from that.
mtias commentedon Apr 27, 2017
I don't have a strong opinion here :)
3 remaining items
jasmussen commentedon Jun 6, 2017
Can we close this one as fixed now that the embed block is in?
StaggerLeee commentedon Jul 13, 2017
Maybe I am just a bit lazy, but I cannot see option to insert/embed video from local server ?
I mean upload to Media Library, and chose it same way as image/gallery.