Skip to content

Add Block: Embed #316

Closed
Closed

Description

@mtias

Attributes

  • Alignment: None, Left, Right, Center, Full Bleed.
  • Change url.

Markup

<!-- wp:embed -->
http://embedurl
<!-- /wp -->

States (see all)

image

image

Activity

  1. added
    FrameworkIssues related to broader framework topics, especially as it relates to javascript
    [Type] TaskIssues or PRs that have been broken down into an individual action to take
    on Mar 23, 2017
  2. self-assigned this
    on Apr 14, 2017
  3. added this to the Prototype Parity milestone on Apr 20, 2017
  4. aduth commented on Apr 21, 2017

    @aduth
    Member

    What's the markup of an embed block which has a caption assigned?

  5. mtias commented on Apr 26, 2017

    @mtias
    MemberAuthor

    @jasmussen thoughts on caption there? I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.

  6. ellatrix commented on Apr 26, 2017

    @ellatrix
    Member

    Why would it not?

  7. jasmussen commented on Apr 26, 2017

    @jasmussen
    Contributor

    I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.

    So long as I can make a linebreak, center and italicize some text, I don't have strong opinion.

    I think in general, it makes sense for media items, but if you embed something and the resulting block is something non media related, yeah probably would feel weird with a caption.

  8. removed their assignment
    on Apr 26, 2017
  9. mtias commented on Apr 26, 2017

    @mtias
    MemberAuthor

    Yes, that's my hesitance, it'd feel spurious in some embeds and adds some visual and cognitive weight.

  10. ellatrix commented on Apr 26, 2017

    @ellatrix
    Member

    Somehow, I do like that all "object blocks" would have the same markup and caption support.

    <figure>
      <!-- children -->
      <figcaption>Caption.</figcaption>
    <figure>

    Whether it's an image, gallery, embed, table, or other form of data visualisation.

  11. ellatrix commented on Apr 26, 2017

    @ellatrix
    Member

    In the case of oEmbed, this could still be the link to the resource. It's valid to store it in a figure, and it comes with some handy things like floating.

    <figure>https://www.youtube.com/watch?v=Nl6U7UotA-M</figure>
    <figure class="alignright">
      https://www.youtube.com/watch?v=Nl6U7UotA-M
      <figcaption>Caption.</figcaption>
    <figure>
  12. jasmussen commented on Apr 27, 2017

    @jasmussen
    Contributor

    I think you both make really solid arguments here.

    Can we "wait and see what feels right" on this one? Or are there other ways we can get closer to a consensus? Do we have a list of all supported oembeds? Maybe we can look at the list and see if a whole bunch of them would look super weird with captions, and decide from that.

  13. mtias commented on Apr 27, 2017

    @mtias
    MemberAuthor

    I don't have a strong opinion here :)

  14. removed this from the Prototype Parity milestone on Apr 28, 2017
  15. 3 remaining items

  16. jasmussen commented on Jun 6, 2017

    @jasmussen
    Contributor

    Can we close this one as fixed now that the embed block is in?

  17. StaggerLeee commented on Jul 13, 2017

    @StaggerLeee

    Maybe I am just a bit lazy, but I cannot see option to insert/embed video from local server ?
    I mean upload to Media Library, and chose it same way as image/gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] BlocksOverall functionality of blocks[Type] TaskIssues or PRs that have been broken down into an individual action to take

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions