Skip to content

fix: remove name parameter from exchanges.get method - #141

Merged
m00sey merged 2 commits into
WebOfTrust:developmentfrom
lenkan:fix-removal-exchanges-name-parameter
Nov 21, 2023
Merged

fix: remove name parameter from exchanges.get method#141
m00sey merged 2 commits into
WebOfTrust:developmentfrom
lenkan:fix-removal-exchanges-name-parameter

Conversation

@lenkan

@lenkan lenkan commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

Please merge this only if you decide to merge the corresponding PR in keria WebOfTrust/keria#128.

@codecov

codecov Bot commented Nov 16, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (645d665) 81.01% compared to head (9725ede) 81.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #141   +/-   ##
============================================
  Coverage        81.01%   81.01%           
============================================
  Files               46       46           
  Lines             4187     4187           
  Branches          1028     1028           
============================================
  Hits              3392     3392           
  Misses             763      763           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m00sey m00sey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m00sey
m00sey merged commit bcd83fc into WebOfTrust:development Nov 21, 2023
@lenkan
lenkan deleted the fix-removal-exchanges-name-parameter branch December 4, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants