remove habname from exchange query - #128
Merged
pfeairheller merged 1 commit intoNov 20, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #128 +/- ##
===============================================
+ Coverage 91.66% 91.69% +0.02%
===============================================
Files 37 37
Lines 5987 5981 -6
===============================================
- Hits 5488 5484 -4
+ Misses 499 497 -2 ☔ View full report in Codecov by Sentry. |
lenkan
marked this pull request as ready for review
November 16, 2023 16:00
Collaborator
Author
|
We could also consider changing the POST /identifiers/{name}/exchanges to POST /exchanges and put the |
Collaborator
Author
|
@pfeairheller Have you had a chance to look at this? |
Member
Yes, just waited until this morning when I had a chance to update the SigPy client before merging. |
8 tasks
lenkan
pushed a commit
to lenkan/keria
that referenced
this pull request
Nov 6, 2025
remove unused dependencies, move dev dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion to resolve #127
See issue for rationale.