Skip to content

Enable support for CoreInstance to assemble and execute string instructions via LLVM - SE-145#253

Closed
rahahahat wants to merge 1 commit intodevfrom
llvm-support-coreins
Closed

Enable support for CoreInstance to assemble and execute string instructions via LLVM - SE-145#253
rahahahat wants to merge 1 commit intodevfrom
llvm-support-coreins

Conversation

@rahahahat
Copy link
Copy Markdown
Contributor

This PR adds a new constructor to CoreInstance (CoreInstance::CoreInstance(std::string instructions, std::string configPath)). This constructor is only available after specifying the flag -DSIMENG_ENABLE_TESTS=ON. Calling this constructor with a string of instructions and a config path will assemble the string of instructions via LLVM and construct the process image with the assembled source. SimEng is then able to execute these assembled instructions. This constructor is not exposed to main.cc so this functionality is not accessible through the compiled SimEng executable.
This feature will mainly be used for testing SST. Instructions supplied via TEST_GROUP(s) will be assembled via this constructor and executed.

@rahahahat rahahahat requested review from FinnWilkinson, dANW34V3R and jj16791 and removed request for dANW34V3R and jj16791 October 10, 2022 16:55
@FinnWilkinson
Copy link
Copy Markdown
Contributor

Given that the SimEng test suite also has a very similar function, would it be worth creating this function once to suit both use cases?

@FinnWilkinson
Copy link
Copy Markdown
Contributor

FinnWilkinson commented Oct 10, 2022

Additionally PR #248 Updates the LLVM version used in SimEng to 14.0.5, so it may be worth implementing these changes after that PR (given #248 updates the test suite function and ensures backwards compatability)? Open to thoughts on this from all

@rahahahat rahahahat self-assigned this Oct 10, 2022
@rahahahat rahahahat added the enhancement New feature or request label Oct 10, 2022
@rahahahat rahahahat closed this Oct 11, 2022
@rahahahat rahahahat deleted the llvm-support-coreins branch October 18, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants