Skip to content

Integrate Group Manager to soccer/retrain with POCA#5115

Merged
andrewcoh merged 5 commits into
mainfrom
develop-groupman-soccer
Mar 15, 2021
Merged

Integrate Group Manager to soccer/retrain with POCA#5115
andrewcoh merged 5 commits into
mainfrom
develop-groupman-soccer

Conversation

@andrewcoh

@andrewcoh andrewcoh commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Proposed change(s)

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

ervteng
ervteng reviewed Mar 15, 2021
View reviewed changes
Comment thread docs/Learning-Environment-Examples.md
- Get the ball into the opponent's goal while preventing the ball from
entering own goal.
- Agents: The environment contains four agents, with the same Behavior
- Agents: The environment contains two different Multi Agent Groups with two agents in each.

@ervteng ervteng Mar 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we have to call out explicitly the implementation here. We can just say "The environment contains two opposing groups of agents, each with two agents."

dongruoping
dongruoping approved these changes Mar 15, 2021
View reviewed changes

@dongruoping dongruoping left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcoh andrewcoh merged commit 450e522 into main Mar 15, 2021
@delete-merged-branch delete-merged-branch Bot deleted the develop-groupman-soccer branch March 15, 2021 22:37
ervteng pushed a commit that referenced this pull request Mar 15, 2021
@andrewcoh
Integrate Group Manager to soccer/retrain with POCA (#5115)
61c7298
@ervteng ervteng mentioned this pull request Mar 15, 2021
Merged
10 tasks
ervteng pushed a commit that referenced this pull request Mar 16, 2021
@andrewcoh
[cherry-pick] Integrate Group Manager to soccer/retrain with POCA (#5115
47c5c56 
) (#5121)

* Integrate Group Manager to soccer/retrain with POCA (#5115)

* Add Soccer env to changelog

Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
@dongruoping dongruoping mentioned this pull request Jun 7, 2021
Merged
10 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hunter-Unity Hunter-Unity Awaiting requested review from Hunter-Unity

2 more reviewers

@ervteng ervteng ervteng approved these changes

@dongruoping dongruoping dongruoping approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewcoh @ervteng @dongruoping