Repository navigation
Remove dead/broken Laravel auth scaffolding controllers - #25
Merged
Merged
Conversation
Closes #23. app/Http/Controllers/Auth/{Login,Register,ForgotPassword,ResetPassword}Controller.php were leftover Laravel UI scaffolding that has been broken since the Helium/App namespace split: they `use Helium\Http\Controllers\Controller`, but the base controller only exists as `App\Http\Controllers\Controller`, so `class_exists()` on any of them throws immediately. LoginController additionally used `Illuminate\Foundation\Auth\AuthenticatesUsers`, a trait that hasn't shipped with Laravel core in years (it lived in laravel/ui, which isn't a dependency here). None of this was reachable: the real /login, /register and /password/* routes are inline closures in routes/web.php. Deleting rather than fixing since there's nothing to migrate onto them. Verified: full PHPUnit suite (386 tests) still passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u3o4QCgpcqH51edYyRPMn
5 tasks done
matbrgz
changed the base branch from
chore/docker-deps-boca-review
to
master
September 10, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
Summary
app/Http/Controllers/Auth/{Login,Register,ForgotPassword,ResetPassword}Controller.php— leftover Laravel UI scaffolding that's been broken since theHelium/Appnamespace split (use Helium\Http\Controllers\Controller, but that class only exists asApp\Http\Controllers\Controller), andLoginControlleralso referencedIlluminate\Foundation\Auth\AuthenticatesUsers, a trait that isn't installed (used to ship withlaravel/ui, not a dependency here)./login,/register,/password/*routes are inline closures inroutes/web.php. Nothing to migrate onto them, so deleting rather than fixing.Test plan
class_exists()reproduction of the bug confirmed before the fix (see issue Dead/broken Laravel auth scaffolding controllers (wrong namespace, non-existent traits) #23)Stacked on #24 (base branch
chore/docker-deps-boca-review) since that's what has a working Docker/test setup to verify against.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
🤖 Generated with Claude Code
https://claude.ai/code/session_011u3o4QCgpcqH51edYyRPMn