Skip to content

Dead/broken Laravel auth scaffolding controllers (wrong namespace, non-existent traits) #23

Closed

Description

@matbrgz

Summary

app/Http/Controllers/Auth/{LoginController,RegisterController,ForgotPasswordController,ResetPasswordController}.php are dead code left over from an old Laravel UI scaffold, and are broken in two independent ways. They aren't used today (the real login/register/password-reset routes are inline closures in routes/web.php), but they're landmines for anyone who tries to wire them up, and they'll break any tool that eagerly autoloads/classmaps the app/ tree.

Evidence

  • All four use Helium\Http\Controllers\Controller; — but the base controller is declared namespace App\Http\Controllers; in app/Http/Controllers/Controller.php. Composer's autoload maps both App\ and Helium\ to app/ (see composer.json), so the file loads, but the class Helium\Http\Controllers\Controller never gets defined, only App\Http\Controllers\Controller does.
  • Confirmed by direct reproduction: class_exists('Helium\\Http\\Controllers\\Auth\\LoginController', true) throws Class "Helium\Http\Controllers\Controller" not found.
  • LoginController additionally use AuthenticatesUsers; from Illuminate\Foundation\Auth\AuthenticatesUsers — this trait doesn't exist anywhere in the installed vendor/ (it used to ship with laravel/ui, which isn't a dependency here). Same issue likely applies to the traits used by the other three controllers (RegistersUsers, SendsPasswordResetEmails, ResetsPasswords).
  • None of routes/web.php's actual /login, /register, /password/* routes reference these classes — they're all inline closures, so this dead code currently causes no visible failure.

Suggested scope

Delete the four files (and the now-empty app/Http/Controllers/Auth/ directory) unless there's a plan to actually migrate routes/web.php's closure-based auth back onto controllers — in which case they'd need to be rewritten against the current App\Http\Controllers\Controller and Laravel 13's actual auth APIs (no more AuthenticatesUsers-style traits without adding laravel/ui or laravel/fortify).


Found via a functional, hands-on audit of the auth flow while verifying microHelium's BOCA feature parity.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions