Repository navigation
docs: a sweep that could not find its own founding case (#2492) - #2501
Merged
Merged
Conversation
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After fixing
--invert(#2500) I swept all 55 boolean flags in thetriCLI for the same shape — declared, and barely referenced.Seven surfaced at a "two or fewer references" threshold. Every one was a correct forward: the declaration plus the call it feeds. Two references is what a working flag looks like.
And
--invert, with the bug in place, had three — signature,if invert, destructure. The threshold would have cleared it.The flag was used. It was used in a
println!. Static reference-counting cannot express the difference between a mode and a decoration; only a test demanding the mode produce a different result can.Filed as a null result with its own limit stated, rather than "seven candidates, all clean" — which would have read as coverage of a class this instrument cannot see.
Refs #2492