Repository navigation
fix(tri): --invert was a banner over a silent run; add --all (#2492) - #2500
Merged
Merged
Conversation
Direction::Invert was declared, documented and never constructed.
invert_sites() was written, unit-tested, and had zero callers. mutate()
chose `if loud { Loud } else { Silent }`, so `--invert` printed an
invert banner and measured the silent operator.
Proven two ways before the fix: statically (0 calls, variant never
constructed) and empirically (--invert and the default printed byte
identical rows).
The published "one invert survivor, the same declared branch" was the
silent survivor relabelled. It read as correct BECAUSE it was a real
measurement of the wrong thing -- number-audit 8.6: the observation was
right and the reason was invented.
All ten existing tests passed with the bug present; each exercised
invert_sites() or sites_in_direction() alone and none joined them. That
is the defect this command exists to find -- function covered, wiring to
the answer not -- arriving one level up, in the auditor.
Adds --all: three operators, one pass, three columns. Reading them apart
is what let the substitution stand.
Refs #2492
The published "one invert survivor" was the silent survivor relabelled. Real first measurement: 33 invert mutants across 13 gates, 33 killed. ci-gates SKILL.md §36: a flag can be a banner. The output was plausible and "the same branch as the other operators" was true by construction -- it WAS the other operator. Check: assert a new mode produces something the others do not, on a fixture where all have a site. Equality across modes is the signature of a fall-through. Refs #2492
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tri gates mutate --invertshipped in #2499, merged, and published a number. It never ran the invert operator.Direction::Invertwas declared and documented.invert_sites()was written and unit-tested. Nothing joined them:mutate()chose its direction withif loud { Loud } else { Silent }, so the flag printed an invert banner over a silent run.Proven two ways before touching it
invert_sites()in non-test code,Direction::Invertnever constructed--invertand the default printed byte-identical rowsWhy it stood
The published result — "one survivor,
check_elab_ratchet's no-baseline branch, the same one both other operators leave" — was true in every part, and the last clause was true by construction: it was the other operator. A real measurement of the wrong thing agrees with the story you already have.All ten existing tests passed with the bug present. Each exercised
invert_sites()orsites_in_direction()alone; none crossed between them — the defect this command exists to find, one level up in the auditor.Changes
sites_in_directiondelegatesDirection::Inverttoinvert_siteseach_direction_reaches_its_own_operator: three distinct sites on one fixture, asserting the three site sets differ. Verified RED on the restored bug, green without it.--all: three operators, one pass, three columns. Reading them apart is what let the substitution stand.First honest measurement
33 invert mutants across 13 gates, 33 killed, no survivors. The columns disagree where they must:
check_json_parsesone silent site and no invertible condition,check_vector_datafive inverts against four silents. The suite's one remaining survivor is unchanged —check_elab_ratchet.py's no-baseline branch under the silent operator, declaredUNCOVERED.Refs #2492