Skip to content

fix(gen-verilog): a field of an array element of a struct resolves as one part-select - #2428

Merged
gHashTag merged 1 commit into
masterfrom
fix/nested-array-struct-path
Aug 22, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/nested-array-struct-path

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Refs #2325. Second slice of the flattened-prefix family: 228 -> 213 elaboration errors. The first attempt introduced a glued part-select and was caught by the smoke run before leaving the worktree — the landed version resolves the whole trailing chain. Smoke 32/32, both vector modules pass.

🤖 Generated with Claude Code

… one part-select

mem.ports[i].kind resolved its base to nothing and flattened to _kind --
a name with an empty base that can never bind. The path now lowers to a
single cumulative part-select over the outer struct's packed bits.

The first version handled exactly one trailing field and emitted a
part-select with an identifier glued to it for a two-field tail, which is
the #2240 defect in a new place; yosys caught it inside one smoke run
(32 -> 31) and it never left the worktree. The landed version walks the
whole trailing chain.

Measured: 228 -> 213 elaboration errors over the 32-module set, on top of
573 -> 228 from the string-field fix; yosys smoke 32/32; both executed
vector modules pass; cargo test unchanged at the 13 failures that are red
on clean master too (#2292). M5 performed.

Refs #2325.
@gHashTag
gHashTag enabled auto-merge (squash) August 22, 2026 14:35
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-22 14:38:45 UTC

Summary

Status Count
Total Open PRs 5
PRs with Failing Checks 2
PRs with All Checks Green 3
READY 3
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=0533a1a715c6 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit eec7e99 into master Aug 22, 2026
26 of 29 checks passed
@gHashTag
gHashTag deleted the fix/nested-array-struct-path branch October 26, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant