Repository navigation
fix(gen-verilog): a field of an array element of a struct resolves as one part-select - #2428
Merged
Merged
Conversation
… one part-select mem.ports[i].kind resolved its base to nothing and flattened to _kind -- a name with an empty base that can never bind. The path now lowers to a single cumulative part-select over the outer struct's packed bits. The first version handled exactly one trailing field and emitted a part-select with an identifier glued to it for a two-field tail, which is the #2240 defect in a new place; yosys caught it inside one smoke run (32 -> 31) and it never left the worktree. The landed version walks the whole trailing chain. Measured: 228 -> 213 elaboration errors over the 32-module set, on top of 573 -> 228 from the string-field fix; yosys smoke 32/32; both executed vector modules pass; cargo test unchanged at the 13 failures that are red on clean master too (#2292). M5 performed. Refs #2325.
gHashTag
enabled auto-merge (squash)
August 22, 2026 14:35
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2325. Second slice of the flattened-prefix family: 228 -> 213 elaboration errors. The first attempt introduced a glued part-select and was caught by the smoke run before leaving the worktree — the landed version resolves the whole trailing chain. Smoke 32/32, both vector modules pass.
🤖 Generated with Claude Code