Repository navigation
test(gen-python): hello_world announces four fns, not three (Closes #12195) - #12196
Merged
Merged
Conversation
…12195) #6987 added `pub fn on_comb` to specs/demos/hello_world.t27 on 2026-10-22; this expectation was written on 2026-10-04 against the three-fn spec and has been red on master ever since (Bootstrap Test Ratchet run 40111271692 lists it under newly failing). Count the fns the spec actually holds and say so in the doc comment -- both edits in place, so the own-language budget nets zero.
gHashTag
enabled auto-merge (squash)
October 25, 2026 03:49
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12195
Description
specs/demos/hello_world.t27gained a fourth function (pub fn on_comb) in#6987, but
gen_python_hello_world_parses_and_importsstill counts the threefns the spec held when the test was written on 2026-10-04. The assertion has
been red on master ever since (Bootstrap Test Ratchet run 40111271692 lists it
under "newly failing"), so every PR carries a failure nobody owns.
Changes
bootstrap/tests/gen_python_behaviour.rs— count 3 -> 4 on the"was not emitted -- this backend lowers declarations" assertion, and the doc
comment above it says four fns instead of three. Both edits in place.
Testing
Review Notes
The generator and the spec are untouched: only the stale expectation moves.
No hand-written foreign line is added (shrink-only budget holds).