Skip to content

test(gen-python): hello_world announces four fns, not three (Closes #12195) - #12196

Merged
gHashTag merged 1 commit into
masterfrom
fix/gen-python-hello-world-12195
Oct 25, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/gen-python-hello-world-12195

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Closes #12195

Description

specs/demos/hello_world.t27 gained a fourth function (pub fn on_comb) in
#6987, but gen_python_hello_world_parses_and_imports still counts the three
fns the spec held when the test was written on 2026-10-04. The assertion has
been red on master ever since (Bootstrap Test Ratchet run 40111271692 lists it
under "newly failing"), so every PR carries a failure nobody owns.

Changes

  • bootstrap/tests/gen_python_behaviour.rs — count 3 -> 4 on the
    "was not emitted -- this backend lowers declarations" assertion, and the doc
    comment above it says four fns instead of three. Both edits in place.

Testing

cargo test --test gen_python_behaviour
# test result: ok. 5 passed; 0 failed
git diff --numstat master...HEAD
# 2	2	bootstrap/tests/gen_python_behaviour.rs   (own-language net 0)

Review Notes

The generator and the spec are untouched: only the stale expectation moves.
No hand-written foreign line is added (shrink-only budget holds).

…12195)

#6987 added `pub fn on_comb` to specs/demos/hello_world.t27 on 2026-10-22;
this expectation was written on 2026-10-04 against the three-fn spec and has
been red on master ever since (Bootstrap Test Ratchet run 40111271692 lists it
under newly failing). Count the fns the spec actually holds and say so in the
doc comment -- both edits in place, so the own-language budget nets zero.
@gHashTag
gHashTag enabled auto-merge (squash) October 25, 2026 03:49
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-25 03:49:43 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 43
PRs with All Checks Green 7
READY 6
FAILING 43
PENDING 0
NO CHECKS YET 0

These columns do not partition: 6 + 43 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=55c0f1b1b32d != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 1c783b0 into master Oct 25, 2026
38 of 41 checks passed
@gHashTag
gHashTag deleted the fix/gen-python-hello-world-12195 branch October 26, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen_python test expects 3 fns; hello_world.t27 has had 4 since #6987 (red on master)

2 participants