Skip to content

fix(specs): lt_s, sar32, digit_byte import their originals -- master duplicate-bodies green (Closes #11885) - #11886

Merged
gHashTag merged 6 commits into
masterfrom
night/15-dupe-bodies-master
Oct 25, 2026
Merged

gHashTag merged 6 commits into
masterfrom
night/15-dupe-bodies-master

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Closes #11885

Master f308c93 fails duplicate-bodies on every open PR: wasm_opcodes.t27 (#11867) restated wasm_interp.t27's lt_s and sar32, and a11y_mirror.t27 (#11849) restated claw/text.t27's digit_byte. Both files now use the original instead.

  • python3 tools/dupe_scan.py: ok, 1855 -> 1849 copied bodies, no group grew.
  • T27 OS lab: dispatched on e1d4424 (run 40007845458) for both specs; the receipt lands in Trinity-S-AI-DNA/t27os runs/e1d4424c4df1fc609a4ebf960377c5a58800b2b5.*.json. The PR stays draft until it shows t27c and t27b green.
  • Known gap: the two seals (.trinity/seals/fpga_fpga_wasm_opcodes.json, t27f_a11y_mirror.json) go stale. Resealing needs a master-built t27c, and the night tick has none (the same blocker as fix(tri): NONE sentinels are 4294967295, not 2^64-1 -- wasm32 usize (Refs #11840) #11845: the Railway fs-lab needs an owner railway login). Master is already red on Seal Coverage.

🤖 Generated with Claude Code

…t their originals (Refs #11885)

wasm_opcodes.t27 (#11867) restated wasm_interp.t27's lt_s and sar32, and
a11y_mirror.t27 (#11849) restated claw/text.t27's digit_byte; dupe_scan
turned master's duplicate-bodies red for every open PR. Both now `use`
the original. dupe_scan: ok, 1855 -> 1849 copied bodies.

Closes #11885

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gHashTag gHashTag added the no-auto-merge Opt out of the issue gate's default squash auto-merge (issue-gate.yml) label Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-23 19:00:21 UTC

Summary

Status Count
Total Open PRs 35
PRs with Failing Checks 31
PRs with All Checks Green 4
READY 4
FAILING 31
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=5aec047d42ec != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag

Copy link
Copy Markdown
Collaborator Author

T27 OS lab receipt: Trinity-S-AI-DNA/t27os runs/e1d4424c4df1fc609a4ebf960377c5a58800b2b5.f4cc1dd4.json (run 40007845458, t27c built at e1d4424).

@gHashTag

Copy link
Copy Markdown
Collaborator Author

Night tick 17 (CI triage): this PR's fpga-lint and fpga-conformance failures are inherited, not caused by the two-file dedupe.

There are two ways to repair it on master: make the two wasm specs lowerable (fix the emitter classes behind the 155 errors), or take a deliberate check_elab_ratchet --update-baseline that cites #11864 and #11867. This tick does neither, because both are master-scope work.

Refs #11885

@gHashTag

Copy link
Copy Markdown
Collaborator Author

Night tick 27, t27b leg for head e1d4424 (t27b-native-ratchet run 40007901910, artifact t27b-native-run/run.json, ubuntu-24.04-arm):

  • specs/fpga/wasm_opcodes.t27: t27b pass, 13 tests / null asserts (reference pass)
  • specs/t27f/a11y_mirror.t27: t27b pass, 6 tests / 250 asserts (reference pass)

The check is red for ledger staleness only: 0 UNEXPECTED FAILURE, 23 UNEXPECTED PASS, 54 UNLISTED. Master f308c93 is red the same way (run 40001627259), so this red comes from master, not from this PR. Both compiler legs are now on record (t27c from the T27 OS lab receipt, t27b here). Refs #11889.

@gHashTag

Copy link
Copy Markdown
Collaborator Author

Night tick 36: #11926 records the master copies in tools/duplicate_bodies_baseline.txt so master's dupe ratchet goes green. When this PR removes its copies, it must also take its lines back out of that ledger in the same commit (python3 tools/dupe_scan.py --bless); otherwise the ratchet fails with 'the corpus improved and the ledger did not move'.

gHashTag added a commit that referenced this pull request Oct 24, 2026
… every PR red (Refs #11885) (#11926)

Master's Duplicate Body Ratchet (run 40039980757 on 3e47410) fails on
four groups that merged PRs copied: digit_byte (claw/text, t27f/a11y_mirror),
lt_s and sar32 (fpga/wasm_interp, fpga/wasm_opcodes), sort_asc_u32
(t27f/measure_live). Every open PR inherits that red.

This commit writes exactly the four lines --bless writes, in its order,
and nothing else. The copies are still real: #11886 and #11916 remove
them, and each must move these lines back down in the same commit.

No spec changes, so no seal or compiler leg moves.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag and others added 2 commits October 24, 2026 07:36
@gHashTag

Copy link
Copy Markdown
Collaborator Author

night tick 169 taken. Plan: undraft when fpga-bitstream (run 40168167194, queued) is green. Done so far: 39/39 checks pass on 688182c, fpga 6/7 jobs success; lab receipt 68899a6 green both legs.

@gHashTag

Copy link
Copy Markdown
Collaborator Author

Night tick 172: undrafted. Head 688182c: 41 checks pass, 0 fail; fpga-bitstream run 40168167194 success; lab receipt (both compilers) on record from tick 169.

@tri-claw

tri-claw Bot commented Oct 25, 2026

Copy link
Copy Markdown

Summary by t27-bees

Checked by the t27 compiler

t27c parse, parse-complete and typecheck on each changed .t27 file at 688182c. Nothing was generated, built or run. A pass means the file is well formed, not that it is right.

  • specs/fpga/wasm_opcodes.t27: parses and typechecks.
  • specs/t27f/a11y_mirror.t27: parses and typechecks.

Read by the model

This PR eliminates duplicate function bodies by having wasm_opcodes.t27 import lt_s and sar32 from wasm_interp.t27, and a11y_mirror.t27 import digit_byte from claw/text.t27. The duplicate-body scan baseline drops from 1855 to 1849.

Worth a look

  • specs/t27f/a11y_mirror.t27:96 — The call site now passes (x % 10) as u32 to the imported digit_byte, whereas the original local definition took u64. The compiler accepts it, so the imported signature likely differs; verify the semantic equivalence (e.g., behavior for values ≥ 2³²).
  • .trinity/seals/fpga_fpga_wasm_opcodes.json and .trinity/seals/t27f_a11y_mirror.json — Both seals carry new hashes and timestamps from a local bootstrap build (t27c-bootstrap@0.5.2+68899a628). The PR description notes these will go stale until resealed from a master-built t27c; treat the seal updates as provisional.

Read: 5 files, +24 -49, the whole diff. Head 688182c. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

@gHashTag
gHashTag merged commit 9c3b91a into master Oct 25, 2026
45 checks passed
@gHashTag
gHashTag deleted the night/15-dupe-bodies-master branch October 26, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-auto-merge Opt out of the issue gate's default squash auto-merge (issue-gate.yml)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

master red: duplicate-bodies (lt_s, sar32, digit_byte copied by #11867 and #11849)

1 participant