Repository navigation
docs(analog): the sar_adc record says "reference scan", not "hand scan" (Refs #12117) - #12118
Merged
Merged
Conversation
…n" -- the scan is written in the test (Refs #12117) The t27-bees review of PR #12108 pointed at the phrase: the fit_cp test does not compare against a scan done by hand, it re-scores all 41 Cp points with match_count and miss_margins inside the test. Say that, and say what it does and does not check (the choice rule, not those two functions). No number changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Summary by t27-beesThis PR updates the SAR ADC mutation documentation to replace "hand scan" with "reference scan" in two places, adding a sentence explaining that the reference scan is computed in the test by reusing Worth a look
Read: 1 files, +5 -3, the whole diff. Head |
29 of 39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/analog/mutation-sar_adc-2026-10-25.md: "hand scan" becomes "reference scan" in the survivor table and in the test list, with one sentence on what the scan is (written in the test, reusesmatch_countandmiss_margins) and what pins the first-of-the-ties case (the third test).Why
The t27-bees review of PR #12108 flagged that the test computes its expectation algorithmically while the record said "hand scan". The reviewer is right about the wording; the other items of that review (a sentinel that cannot be reached, a literal
2that is theparargument also passed tomiss_margins, deterministic bisection bounds, line-number coupling that the record already states) were read against the code and need no change.Refs #12117 (the sar_kick half of that issue needs the pane server back and follows in a second PR).
🤖 Generated with Claude Code