Repository navigation
test(t27os): queen_chats asserts the length byte, not dead memory (Refs #3) - #11915
Merged
Merged
Conversation
#3) The failing assert read t[5] of an undefined [512]u8 buffer -- a byte rc_paste never writes. The two compilers disagree on undefined memory (t27c/Zig debug fills 0xAA, t27b zero-fills), so the assert passed under t27b and failed under the reference: a compiler-dependent test, not a spec defect. rc_paste's own law (the length byte at RC_TEXT_MAX, the printable join stopped at the cap) defines the byte the test now checks: t[RC_TEXT_MAX] == 5 -- same intent, a defined byte. 5/5 both compilers, the paste-cap asserts untouched.
gHashTag
enabled auto-merge
October 23, 2026 22:56
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing assert read an undefined-buffer byte the spec's rc_paste never writes. The two compilers disagree on undefined memory (t27c/Zig debug = 0xAA fill, t27b = zero-fill), so the test was compiler-dependent: it passed under t27b and failed under the reference. The fix asserts the byte the spec defines — the length byte at RC_TEXT_MAX == 5, the same intent on a defined byte. 5/5 both compilers after.