Repository navigation
fix(ui): settings say each thing once; inline friend Bot remove; clearer Sharing (part of #230) - #232
Conversation
…rer Sharing (part of ThinkFlowLab#230)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4f6b7a88a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| disabled: !!busy, | ||
| onClick: () => { void removeBot() }, | ||
| }, busy ? 'Removing…' : 'Remove this Bot'), | ||
| `Auto-send to ${who}`), |
There was a problem hiding this comment.
When a friend's home/display name is long (cleanText permits 60 characters at plugins/social/src/social.js:84), this new text cannot fit the compact remote-Bot settings sheet: that sheet is capped at 320px (core/src/client/remote-bot-settings.js:13), the card at 280px, and the .fs-auto rule at plugins/social/client.js:61 forces white-space:nowrap. The override added at line 77 does not re-enable wrapping or ellipsis, so the settings body gets horizontal overflow and the friend name this change is meant to identify is clipped/off-screen; constrain or wrap the label.
Useful? React with 👍 / 👎.
…ThinkFlowLab#263) Fixes ThinkFlowLab#230 The last open item of ThinkFlowLab#230: **Create Bot starts on the Main Bot's model**, not on the DeepSeek Harness default. `startModel()` (`core/src/client/bot-draft.js`) now picks, in order, the first one that DSH serves: 1. the Main Bot's chosen model, else the one it last ran on; 2. `roster.defaultModel` (the DSH default); 3. the first served model. Only served models are picked, so a model whose provider has lost its credential (and so is not served) is never preselected. Also: unit tests for each fallback, a `core/README.md` line, the `core-client.md` subsystem note, a changelog fragment, the rebuilt client bundle and the regenerated ds-bot patches (`bot-draft.js` and `create-bot.test.js` added to topic `0003-flybot-api-client`, `README.md` to `0001-core-fixes`). The CSS-only items from ThinkFlowLab#232 (heading inset, account menu width, face-room Auto-send row) have tests; the next settings-focused self-test will check them in a browser. Checks (tip `21062d5`): `TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify` passed (core 804/804, social 185/185, tree 56/56, timeline, interop and live-e2e suites green, arch-docs OK). Not run: a live browser run.
What was wrong (#230, the clearly scoped items)
confirm()box, unlike Leave on a face room, which asks inline.What changed
SwitchRowgetsshowLabel: false, and the switch keeps its accessible name.min-width:224px; width:max-content; max-width:calc(100vw - 16px).Remove Helper? Bob can share it again.with Remove and Keep. NoglobalThis.confirm.Auto-send to Bob, in smaller, quieter type.src/client/create-bot.jsis added to topic 0003. Patches andcore/client.jsare regenerated.Not done (still on #230)
Tests
core/test/settings-polish.test.js:SwitchRowhides the label but keeps it on the switch.Auto-send to <friend>.TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verifypasses:tasks.test.js"untagged hold stamps…" and social "[Team] Remove a friend's Bot, and approve held Bot replies inside the chat #90: a hidden Bot shows again…". Both pass in isolation, and neither is touched by this PR.Part of #230