Repository navigation
docs(agents): repair module paths that no longer exist - #908
Closed
lihongyuan99 wants to merge 2 commits into
Closed
lihongyuan99 wants to merge 2 commits into
lihongyuan99 wants to merge 2 commits into
Conversation
Collaborator
|
修 AGENTS.md 过期路径方向好,但有一处必须改: 文中把 schema 断言写成 |
6 of 8 tasks
lihongyuan99
added a commit
to lihongyuan99/Octop
that referenced
this pull request
Sep 22, 2026
The review on TencentCloud#908 caught that `v == 16` was already stale: the number is derived state, and `017_thread_conversation_mode` landed while this PR sat. Name the test that holds the value instead of copying it, so the next migration cannot rot this sentence again.
Contributor
Author
|
Done in 06b8920 — instead of |
4 of 11 tasks
lihongyuan99
added a commit
to lihongyuan99/Octop
that referenced
this pull request
Sep 26, 2026
The review on TencentCloud#908 caught that `v == 16` was already stale: the number is derived state, and `017_thread_conversation_mode` landed while this PR sat. Name the test that holds the value instead of copying it, so the next migration cannot rot this sentence again.
lihongyuan99
force-pushed
the
docs/agents-stale-module-paths
branch
from
September 26, 2026 04:45
06b8920 to
7088cb0
Compare
5 tasks done
Six paths in the layer tables and the "Where to look" map point at modules that are gone after the infra/ reorganisations, and the schema-version hint still says v == 7 while tests/unit/db/test_db_pool.py asserts 16. Each replacement is the module that actually holds the described code today.
The review on TencentCloud#908 caught that `v == 16` was already stale: the number is derived state, and `017_thread_conversation_mode` landed while this PR sat. Name the test that holds the value instead of copying it, so the next migration cannot rot this sentence again.
lihongyuan99
force-pushed
the
docs/agents-stale-module-paths
branch
from
October 3, 2026 14:44
7088cb0 to
476900b
Compare
3 of 10 tasks
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdpointed at module paths that no longer exist, so an agent following the doc would open files that are not there. Each replacement below was checked by resolving the path againstsrc/octop/ondevelop4c3bf764:AGENTS.mdinfra/db/_baseinfra/db/repos/_base.pyinfra/gateway/processor.pyinfra/gateway/process/processor.py(GlobalProcessorat:127)api/errors.pyapi/app.py_install_exception_handlers()(:77)cli/run_cmd.py,cli/init_cmd.py,cli/backup_cmd.py,cli/*_cmd.pycli/commands/run.py,cli/commands/init.py,cli/commands/backup.py,cli/commands/*.pyinfra/gateway/threads.pyrow'sapi/routers/chat.pyapi/routers/chat/(package)infra/agents/manager.py(bare)infra/agents/manager.py(AgentManager.startat:887)The database paragraph said "bump the version assertion in
tests/unit/db/test_db_pool.py(currentlyv == 7)". The literal was wrong twice over while this PR was open (v == 16→v == 17), so it now points at the test that pins the number instead of restating it.After rebasing, every
src/octop/**.pypath referenced inAGENTS.mdresolves — machine-checked with a regex pass over the file against the working tree, which reports zero unresolvable references.Target branch
develop(checked per CONTRIBUTING:mainonly takes releases/hotfixes).Type of change
Test plan
Rebased onto
origin/develop4c3bf764;AGENTS.mdis the only file in the diff (git diff --stat origin/develop..HEAD→1 file changed, 12 insertions(+), 11 deletions(-)).uv run ruff check src tests→All checks passed!uv run ruff format --check src tests→1074 files already formatteduv run mypy src/octop→Success: no issues found in 527 source filesuv run pytest -q -m "not live" -n auto→3820 passed, 18 skipped, 20 warnings in 211.02sAGENTS.md: stale.pyreferences after rebase =NONENo shell script or CLI surface is touched, so there is no bash 3.2 / 5.x behaviour difference to report; the two conflicted hunks were resolved by keeping every
developline (including the newinfra/history/row) and re-applying only the path corrections.Checklist