Repository navigation
docs(agent): repair module paths that no longer resolve - #1109
Closed
lihongyuan99 wants to merge 2 commits into
Closed
lihongyuan99 wants to merge 2 commits into
lihongyuan99 wants to merge 2 commits into
Conversation
7 of 15 tasks
`infra/gateway/processor.py` moved to `infra/gateway/process/processor.py` and the chat router is now the `api/routers/chat/` package, so three present-tense doc tables pointed at files that no longer exist.
`backend_files.py` moved under `infra/gateway/media/` and `AgentBackedMediaBackend` now lives in `media/ingress.py:14`. Both rows describe present-tense state, and the read_bytes fallback they cite is still there at `media/backend_files.py:406`.
lihongyuan99
force-pushed
the
docs/agent-docs-stale-gateway-paths
branch
from
September 25, 2026 04:49
59fea6b to
6ee0871
Compare
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four docs describe present-tense code but point at module paths that no longer exist. Both targets moved out from under them:
GlobalProcessor/ chat routerdocs/agent-call-agent.md:44-45("相关文件") —infra/gateway/processor.py,api/routers/chat.pydocs/agent-delegation.md:25("Octop 侧保留代码") —infra/gateway/processor.pydocs/adr/001-single-process-model.md:35("that seam is already partially visible in …") —infra/gateway/processor.pyGlobalProcessoris atsrc/octop/infra/gateway/process/processor.py:127and is still the class these lines describe:compose_followupat:454,on_replyat:463, the# -- TeamProcessor (delegates to TeamManager)banner at:441, and slash really is dispatched there (:621cmd = parse_slash(msg.text)) — so the "@与 slash" claim stays true. The chat HTTP surface is now the packagesrc/octop/api/routers/chat/(routes.py,models.py,turn.py,ws.py, …); the@mentionrequest field ischat/models.py:66.the
gateway/media/splitdocs/agent-backend-file-io.md:131—infra/gateway/backend_files.pydocs/agent-backend-file-io.md:140—infra/gateway/media.pyAgentBackedMediaBackendbackend_files.pynow sits underinfra/gateway/media/, andAgentBackedMediaBackendis atinfra/gateway/media/ingress.py:14. The "现状" cell beside the first row claims aPath.read_bytesfallback on preview failure, and that is still what the code does (media/backend_files.py:406, documented at:13and:422) — so only the path literal was stale, not the description. The neighbouringinfra/backup/system_archive.py/workspace_archive.pyrows already resolve and were left alone.Only path literals change; no sentence is reworded and no new claim is added.
Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
Nothing in the test suite covers path literals in prose, so this is verified by an executable check instead — a script that pulls every backticked repo-relative path out of these four files and resolves each against both
<root>/<p>and<root>/src/octop/<p>.Before (run against the blobs at base
02a6e28d):After:
Gates, run on this branch to confirm nothing else moved:
uv run ruff check src tests→All checks passed!uv run ruff format --check src tests→1060 files already formattedNo Python is touched (
git diff --stat: 4 files, +6/-6), somypyand pytest are unaffected by this diff and were not re-run.Checklist
CHANGELOG.md(if user-facing) — no runtime behaviour changes; docs-only path repairs carry no entry in this file's historydevelopDeliberately left out
AGENTS.md§5 and §9 ("How is a message processed?") hold the same two staleinfra/gateway/processor.py/api/routers/chat.pyreferences, but docs(agents): repair module paths that no longer exist #908 already rewrites that file — no point landing a second edit on it.docs/agent-interop-mailbox.md:225/298/301also sayinfra/gateway/processor.py, yet its §7 and §9 tables are an implementation plan whose sibling rows (infra/agents/agent_call.py,tests/test_peer_agent.py,tests/test_inbox.py) never landed either. Repairing one row of a stale plan would make the table read as current, so that is a maintainer call rather than a path fix.docs/configuration.md:246referencesinfra/connectors/credential_crypto.py, which does not resolve; that file is already touched by docs(cli): stop naming a command the CLI does not have #965 plus four other open PRs, so it is left alone to avoid a needless conflict pile-up.