Repository navigation
Conversation
Merged
Co-authored-by: rbuergi <6334612+rbuergi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on import changes from review discussion
Restore null-conditional operator for logger in WorkspaceOperations
Nov 1, 2025
rbuergi
marked this pull request as ready for review
November 1, 2025 00:24
rbuergi
added a commit
that referenced
this pull request
Apr 23, 2026
…ityLog feed) KernelContainer no longer exposes `IProgress<string> Progress` to scripts. Scripts now resolve a standard `ILogger` via the `Log` global and call `Log.LogInformation(...)` / `LogWarning(...)` / `LogError(...)` — messages land on the run's ActivityLog MeshNode, which callers stream via `GetRemoteStream<MeshNode, MeshNodeReference>` (same shape as Thread streams). - KernelProgressReporter class + the hidden "progress" area stream: deleted. - Default script usings gain `Microsoft.Extensions.Logging` so LogInformation etc. resolve without an extra using. - OrleansKernelProgressTest rewritten to target the ActivityLog stream; tests are Skip-marked pending the ActivityLog-at-dispatch wiring in task #60. - Doc/AI/ExecuteScript.md: "Watching Progress" section rewritten around the response's ActivityLog path and standard logger calls. Note: `ProgressControl` (the UI progress bar in MeshWeaver.Layout) is unchanged — different concept, nothing to do with the removed kernel global. Follow-up (#60 / #61): create the ActivityLog MeshNode at dispatch, thread the right ILogger into the script so Log calls actually reach that node. Until then, Log messages go to the standard logger infrastructure and the Skip-marked tests stay Skip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback about removing the null-conditional operator from logger usage in
WorkspaceOperations.csline 205.Changes
logger?.LogInformation(...)fromlogger.LogInformation(...)for defensive null safetyWhile the logger is obtained via
GetRequiredService<ILoggerFactory>()which should guarantee non-null, the null-conditional operator prevents runtime exceptions if service registration is misconfigured and aligns with patterns used elsewhere in the codebase (e.g.,TestBase,ImportManager).💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.