Repository navigation
Conversation
Contributor
Test Results483 tests +8 477 ✅ +8 2m 40s ⏱️ +41s Results for commit 48e724a. ± Comparison against base commit 32cc6d2. This pull request removes 10 and adds 18 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This reverts commit c72cb39. # Conflicts: # src/MeshWeaver.Messaging.Hub/MessageService.cs
rbuergi
added a commit
that referenced
this pull request
Apr 23, 2026
…rivate New ExecuteScriptRequest / ExecuteScriptResponse in MeshWeaver.Mesh.Contract (no MeshWeaver.Kernel reference). Handler on the Code node's hub reads the node's CodeConfiguration from its own workspace stream via .Select(change => change.Value).Where(non-null).Take(1).Subscribe(...) — reactive, no .Current snapshot, no await — and fire-and-forget dispatches SubmitCodeRequest to the internal kernel address. Response carries the submission id + layout-area reference so callers can subscribe to live progress without ever addressing the kernel. MeshOperations.ExecuteScript becomes a thin Post-ExecuteScriptRequest-to- the-Code-node-then-RegisterCallback, removing the direct kernel coupling from the MCP surface. Docs: - AsynchronousCalls.md: 🚨 Never read .Current on a stream — use .Select(…).Where(non-null).Take(1).Subscribe. .Current is null on cold workspaces and ships wrong answers. - CqrsAndContentAccess.md: rewritten with the full primitive catalogue (query for sets, GetDataRequest for one-shot content, GetRemoteStream for live updates, PatchDataChangeRequest for writes, named-request types for operations). Concrete ExecuteScript example shows the kernel staying private behind the Code hub handler. Tests: new McpReadYourWritesTest (11/11 green) locks in write→read consistency per MCP method and the ExecuteScript round-trip on an IsExecutable Code node seeded via IMeshService. Task #57 (Get → GetDataRequest) and #58 (Patch → PatchDataChangeRequest) were attempted and reverted: GetDataRequest-served reads after a cross-hub write see stale workspace state (read-your-writes fails). Re-landing after task #59 (per-request hub model) keeps one hub instance alive for the full call chain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing through CollectionPlugin