Repository navigation
roster: Plugins drops its supersede and publish-modules callers (per-module deploy) - #4047
Merged
Merged
Conversation
…module deploy) Systemorph/MeshWeaver.Plugins#1676 stops calling node-repo-supersede.yml (no main run is ever cancelled) and removes the publish-modules caller #1663 added (modules publish on their own verdict). Both rows are marked pending: — compared key for key while Plugins main still has the callers, excused once #1676 merges — so neither Plugins main nor #1676 reds validate in the window. Delete both rows after #1676 merges. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdfUffwySkxQVsoAev4pBm
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Pending entries do not retire automatically and could become stale; tie retirement to caller removal or coordinate deletion.
Pull request overview
Updates the fleet permission roster for Plugins’ planned removal of obsolete CI callers.
Changes:
- Marks
publish-modulesandsupersedeentries as pending removal. - Documents cleanup after Plugins#1676 merges.
File summaries
| File | Summary |
|---|---|
.github/lane-caller-grants.yml |
Updates pending roster entries for Plugins callers. |
Review details
Suppressed comments (2)
.github/lane-caller-grants.yml:86
pendingis only a non-expiring absence exemption: the guard never checks whether Plugins#1676 actually merged or automatically spends the marker. After that PR removes this caller,--fleetwill continue counting and accepting this stale row indefinitely if the promised follow-up deletion is missed, so the roster can again become a false measurement. Please use a retirement transition that is mechanically tied to the removal (or land the deletion as a coordinated follow-up) rather than relying only on prose to remove this row.
pending: REMOVED by Systemorph/MeshWeaver.Plugins#1676 — per-module deploy never cancels a main run, so Plugins no longer calls the supersede lane (ModuleBuildArchitecture → Per-module deploy). Compared key for key while main still has it; the marker excuses the absence once #1676 merges — delete this row then.
.github/lane-caller-grants.yml:81
pendingis only a non-expiring absence exemption: the guard never checks whether Plugins#1676 actually merged or automatically spends the marker. After that PR removes this caller,--fleetwill continue counting and accepting this stale row indefinitely if the promised follow-up deletion is missed, so the roster can again become a false measurement. Please use a retirement transition that is mechanically tied to the removal (or land the deletion as a coordinated follow-up) rather than relying only on prose to remove this row.
pending: on main since Systemorph/MeshWeaver.Plugins#1663 and REMOVED again by Systemorph/MeshWeaver.Plugins#1676 (per-module deploy — ModuleBuildArchitecture → Per-module deploy, so modules publish on their own verdict, not the whole run's). Compared key for key while main still has it; the marker excuses the absence once #1676 merges — delete this row then.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins#1676 (per-module deploy; design of record in
ModuleBuildArchitecture→ Per-module deploy, core #4044) removes two Plugins callers:ci.yml#supersede, because no main run is ever cancelled, andci.yml#publish-modules, added by Plugins#1663, because modules publish on their own verdict. Itsvalidateis red on the fleet-roster assertion, because the roster still listssupersedewithout a marker.Both rows get
pending:. The marker excuses ABSENCE only, so the rows are still compared key for key while Plugins main has the callers, and are excused once #1676 merges.Verified locally:
check-workflow-permission-pairing.py --assert-fleet-row Systemorph/MeshWeaver.Pluginspasses against both the #1676 tree and a main-based tree, and--self-testpasses.Follow-up: delete both rows after #1676 merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LdfUffwySkxQVsoAev4pBm