docs(approvals): mark the Approvals module's relocation to MeshWeaver.Plugins (task #72) — double-ship, tests moved with the module

[rbuergi]

Task #72 (modularization program): the Approvals module relocated to Systemorph/MeshWeaver.Plugins (PR #499) — the Approvals package becomes a MIXED package (node content + compiled module), with the satellite's CI building the module Release -warnaserror against a pinned platform ref (a0a0288d5 = v3.0.0-rc3), executing the relocated tests, and packing the bundle via the reusable module-pack lane (#1664 Slice B / #1673), bundle closure + manifest asserted in CI. This copies the pattern task #63 / MeshWeaver.SocialMedia#31 established for Social, extended per the maintainer directive: the approval tests move to plugins as well.

This platform PR is deliberately NOT the source delete — it is the double-ship marker that keeps the two copies from diverging:

• src/MeshWeaver.Approvals/README.md — records the relocation state, the "platform copy is the MASTER until the flip; mirror .cs verbatim — EXCEPT GraphLegacySurface.cs, which is platform-only" rule, and the exact flip blockers a future delete-PR must resolve:
  1. in-mesh callers of the Approvals surface exist BY CONSTRUCTION (the legacy surface exists because feat(approvals): Approvals rides the module lane — and its views drop hand-built HTML #1654's first image regressed 11 NodeTypes to CompileError): SocialMedia/{Post,PostsHub,Profile}.json configuration lambdas call .AddApprovals() (MeshWeaver.SocialMedia repo), and UWDeepfield/TreatySubmission/Source/… + UWDeepfield/UWDeepfieldHome/Source/UwHomeShims.cs use ApprovalExtensions.ApprovalPartition / ApprovalNodeType.NodeType via using MeshWeaver.Graph (MeshWeaver.Reinsurance repo). NodeType compilation sees only TRUSTED_PLATFORM_ASSEMBLIES (the fix(approvals): restore the legacy MeshWeaver.Graph surface — the ci.3961 bake regression #1683/fix(approvals): the legacy surface is COMPLETE — ci.3971 still regressed on the uncovered classes #1685 AddApprovals breakage class — which WAS this module); a fresh content/ samples/*/Data + node-JSON + live-mesh sweep is mandatory before any symbol is deleted (repo-side sweep done for this PR: content/ and samples/ hold no callers — the callers are in the two satellite repos above and in production databases);
  2. the Memex.Portal.Shared ships-the-bits ProjectReference (this module rides the app closure — no @(MeshModule) entry in memex/MeshModulesPublish.targets);
  3. program-plan task Delete test placeholder for Remove horizontal scrollbar in Recently Viewed section on title page #74's satellite-bundle rollout (until then the registry serves no satellite-built bundles).
     It also records what stays platform-level REGARDLESS of the flip: the Approval record + _Approval→annotations satellite mapping (MeshWeaver.Mesh.Contract), the ApprovalsEnabled marker / HasApprovals() guard (MeshWeaver.Graph), and GraphLegacySurface.cs + ApprovalsLegacySurfaceCompileTest until the in-mesh callers migrate.
• Test relocation (the delta over the Social marker docs(social): mark the Social module's relocation to MeshWeaver.SocialMedia (task #63) — double-ship, platform copy is master until the flip #1688): test/MeshWeaver.Graph.Test/ApprovalModuleTest.cs is DELETED here — it now lives in the satellite as src/MeshWeaver.Approvals.Test (5/5 green there against the pinned ref). ApprovalAndNotificationTest stays (it pins the platform-level Approval/Notification data models); ApprovalsLegacySurfaceCompileTest stays (it pins the PLATFORM's compat surface — a platform contract, not module behavior). The now-unused ProjectReference (Graph.Test → Approvals) and InternalsVisibleTo MeshWeaver.Graph.Test are removed; the satellite csproj grants IVT to MeshWeaver.Approvals.Test instead.
• feat(modules): retire the Approvals→Graph IVT; view packs stay thin-lane pending the static-asset provider (task #67) #1686 IVT verification: the satellite build IS the check — the module compiles clean against the platform with no InternalsVisibleTo from Graph (the Approvals→Graph internals coupling is gone; nothing to hack around).

What's New: skipped — docs + test-relocation marker, no user-visible change (pure relocation; the module keeps shipping identically in the image's app closure), same rationale as #1688.

Verification: satellite sources byte-identical to this repo's copies (cmp over all 5 mirrored .cs); dotnet build src/MeshWeaver.Approvals -c Release -warnaserror and dotnet build test/MeshWeaver.Graph.Test -c Release -warnaserror → 0 warnings, 0 errors; remaining ApprovalAndNotification tests 34/34 green (fresh .trx).

Merge order: after MeshWeaver.Plugins#499 (satellite first — done when both are merged).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Marks the Approvals module relocation to Systemorph/MeshWeaver.Plugins by documenting the double-ship state in the platform repo and removing the now-relocated module tests and related build wiring from MeshWeaver.Graph.Test.

Changes:

• Removed the Approvals module test (ApprovalModuleTest) from the platform repo and dropped the Graph.Test → Approvals ProjectReference.
• Updated src/MeshWeaver.Approvals/README.md to record the relocation state, mirroring rules, and flip blockers.
• Removed the InternalsVisibleTo MeshWeaver.Graph.Test grant from MeshWeaver.Approvals.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
test/MeshWeaver.Graph.Test/MeshWeaver.Graph.Test.csproj	Drops the MeshWeaver.Approvals project reference now that module tests moved to the satellite repo.
test/MeshWeaver.Graph.Test/ApprovalModuleTest.cs	Deletes the module-level tests from the platform test suite (intended relocation).
src/MeshWeaver.Approvals/README.md	Documents relocation/double-ship rules and flip blockers for a future delete/flip PR.
src/MeshWeaver.Approvals/MeshWeaver.Approvals.csproj	Removes IVT to the deleted test assembly to keep the module’s surface clean.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Test Results (shard 5)

1 371 tests   1 370 ✅  4m 59s ⏱️
   11 suites      1 💤
   11 files        0 ❌

Results for commit b22539a.

[github-actions]

Test Results (shard 0)

920 tests   919 ✅  10m 59s ⏱️
 10 suites    1 💤
 10 files      0 ❌

Results for commit b22539a.

[github-actions]

Test Results (shard 4)

1 607 tests   1 601 ✅  7m 34s ⏱️
   11 suites      6 💤
   11 files        0 ❌

Results for commit b22539a.

[github-actions]

Test Results (shard 3)

   11 files     11 suites   7m 8s ⏱️
2 197 tests 2 006 ✅ 191 💤 0 ❌
2 568 runs  2 377 ✅ 191 💤 0 ❌

Results for commit b22539a.

[github-actions]

Test Results (shard 1)

2 164 tests   2 061 ✅  7m 30s ⏱️
   11 suites    103 💤
   11 files        0 ❌

Results for commit b22539a.

[github-actions]

Test Results (shard 2)

2 450 tests   2 446 ✅  7m 40s ⏱️
   11 suites      4 💤
   11 files        0 ❌

Results for commit b22539a.

[github-actions]

Test Results

    65 files      65 suites   45m 53s ⏱️
10 709 tests 10 403 ✅ 306 💤 0 ❌
11 080 runs  10 774 ✅ 306 💤 0 ❌

Results for commit b22539a.