Repository navigation
docs(social): mark the Social module's relocation to MeshWeaver.SocialMedia (task #63) — double-ship, platform copy is master until the flip - #1688
Conversation
…(task #63) — double-ship, platform copy is master until the flip The Social module's sources now also live in MeshWeaver.SocialMedia (src/MeshWeaver.Social — the SocialMedia package became the first MIXED package: content + module, with a CI module-pack bundle lane). The platform keeps shipping its copy via the thin module lane, and this marker is what keeps the two copies from diverging silently: changes land here first and are mirrored verbatim. The README also records the exact flip blockers a future delete-PR must resolve (Memex.Portal.Shared's PlatformCredential coupling per #1681's verdict, the in-mesh AddSocial callers per the #1683/#1685 breakage class, and the #74 satellite-bundle rollout) and what stays when it flips (Modules:Assemblies entries). No user-visible change — no What's New entry (docs-only marker). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Marks the MeshWeaver.Social module’s ongoing relocation to the MeshWeaver.SocialMedia satellite repo by documenting the double-ship contract (platform copy is authoritative until the flip) and pointing future delete/flip work at the known blockers.
Changes:
- Expanded
src/MeshWeaver.Social/README.mdto document relocation status, double-ship rules, and flip blockers. - Added a clarifying note in
memex/MeshModulesPublish.targetspointing maintainers to the relocation doc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MeshWeaver.Social/README.md | Adds relocation/double-ship guidance and enumerates flip blockers to prevent accidental divergence or premature deletion. |
| memex/MeshModulesPublish.targets | Updates the “not flippable” comment to reference the relocation state and the authoritative README. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…program-plan tasks, not GitHub issues (Copilot review) Same finding class abb47c7 fixed for the view-pack comment: a bare '#N' in this repo reads as a GitHub issue/PR reference and sends readers to the wrong tracker. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Test Results (shard 0)919 tests 918 ✅ 10m 51s ⏱️ Results for commit 8bbfe48. |
Test Results (shard 3) 11 files 11 suites 5m 3s ⏱️ Results for commit 8bbfe48. |
Test Results (shard 4)1 606 tests 1 600 ✅ 7m 30s ⏱️ Results for commit 8bbfe48. |
Test Results (shard 5)1 371 tests 1 370 ✅ 6m 14s ⏱️ Results for commit 8bbfe48. |
Test Results (shard 1)2 164 tests 2 061 ✅ 7m 30s ⏱️ Results for commit 8bbfe48. |
Test Results (shard 2)2 447 tests 2 443 ✅ 7m 24s ⏱️ Results for commit 8bbfe48. |
Test Results 65 files 65 suites 44m 34s ⏱️ Results for commit 8bbfe48. |
Task #63 (modularization program): the Social module relocated to Systemorph/MeshWeaver.SocialMedia (PR #31) — the SocialMedia package is now the first MIXED package (node content + compiled module), with the satellite's CI building the module Release
-warnaserroragainst a pinned platform ref and packing the bundle via the reusablemodule-packlane (#1664 Slice B / #1673), bundle closure + manifest asserted in CI.This platform PR is deliberately NOT the source delete — it is the double-ship marker that keeps the two copies from diverging:
src/MeshWeaver.Social/README.md— records the relocation state, the "platform copy is the MASTER until the flip; mirror.csverbatim" rule, and the exact flip blockers a future delete-PR must resolve:Memex.Portal.Sharedcompiles againstPlatformCredential(ApiCredentialNodeTypestays host-side by design) + the ships-the-bits ProjectReference — PR feat(modules): all remaining flippable service modules leave the host build graph (#1644 step 2, task #66) #1681's "not flippable" verdict;SocialExtensions.AddSocial(at leastsamples/Graph/Data/Doc/DataMesh/SocialMedia/{Post,Profile}.jsonconfig lambdas; NodeType compilation sees only TPA — the fix(approvals): restore the legacy MeshWeaver.Graph surface — the ci.3961 bake regression #1683/fix(approvals): the legacy surface is COMPLETE — ci.3971 still regressed on the uncovered classes #1685AddApprovalsbreakage class); a freshcontent/ samples/*/Data+ node-JSON + live-mesh sweep is mandatory before any symbol is deleted;modules/MeshWeaver.Social/is empty by construction and serves nothing).It also records what the flip changes (project +
Memex.Portal.Sharedreference +@(MeshModule)entry removed) and what STAYS (Modules:Assembliesentries — the runtime then loads the landed module frommodules/).memex/MeshModulesPublish.targets— one comment pointing the "Social not flippable" note at the relocation state.What's New: skipped — docs-only marker, no user-visible change (pure relocation; the module keeps shipping identically via the thin lane).
Verification: sources in the satellite are byte-identical to this repo's copies (
cmpover all 13.cs);dotnet build src/MeshWeaver.Social -c Release -warnaserror→ 0 errors; targets file XML-validated; branch rebased on current main (post-#1687).🤖 Generated with Claude Code