fix(runtime): drain shared-memory final close deterministically - #412
Merged
Conversation
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #387.
SharedMemoryControlChannel.DisposeAsyncpreviously started its 250 ms writer fallback immediately after queueing the final Close signal. On a heavily scheduled CI worker, that budget could expire before the writer continuation ever ran, allowing stream disposal to race ahead of the final control signal.The first version of this PR tried to distinguish scheduler delay from a genuinely blocked write by separately observing
_writerActive == 0and_pendingOutboundSignals == 0before queueing Close. That observation was itself racy: another thread could queue a Data/Space signal and let the writer enter a blocking write between the idle/empty check and Close enqueue, causing Dispose to wait indefinitely for Close to start and bypass the 250 ms fallback.The updated fix makes that ownership decision atomic. Writer active state, pending-signal enqueue/dequeue, and Dispose's
idle + empty -> queue Closetransition are serialized by one outbound-state gate. Disposal only waits without a timeout for Close to begin when it atomically proves there is no preceding queued or active write; if any work already exists, it keeps the original bounded 250 ms cleanup path.This preserves the purpose of the fix—do not charge pure writer scheduling delay against the 250 ms blocked-write budget—without allowing a concurrent signal to create an unbounded wait behind an earlier write.
Regression tracked by
SharedMemoryControlChannelTests.DisposeShouldDrainTheFinalCloseSignalBeforeCompletingWakeSource.Supersedes draft #411, which was closed only because the connector's Ready-for-review transition currently errors on an unsupported GraphQL field.