fix(runtime): drain shared-memory final close deterministically - #411
Closed
SunSi12138 wants to merge 1 commit into
Closed
SunSi12138 wants to merge 1 commit into
SunSi12138 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #387.
SharedMemoryControlChannel.DisposeAsyncpreviously started its 250 ms writer fallback immediately after queueing the final Close signal. On a heavily scheduled CI worker, that budget could expire before the writer continuation ever ran, allowing stream disposal to race ahead of the final control signal.This change separates scheduler delay from a genuinely blocked write: when the writer is idle and there are no previously queued signals, disposal waits until the writer has actually dequeued the final Close (or the writer has already exited) before starting the existing bounded write-completion fallback. If a write is already active or work is already queued, the existing bounded cleanup behavior is preserved.
Regression tracked by
SharedMemoryControlChannelTests.DisposeShouldDrainTheFinalCloseSignalBeforeCompletingWakeSource.