[Server][DynamicAdmission] Add atomic runtime enable/disable control - #330
Merged
Merged
Conversation
SunSi12138
marked this pull request as ready for review
August 24, 2026 05:17
SunSi12138
commented
Aug 24, 2026
SunSi12138
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed exact head c1c68580e3337bf640c5c677cce829cae592f423 against #329/#264 and the reviewed #328 base. No remaining P1/P2 found in this runtime enable/disable slice. Candidate build/publication is transactional and linearizable; losing Enable/Stop races retire unpublished candidates; Disable preserves captured queued/active generations; compatible disable→re-enable overlap reuses the stable kernel without splitting queue/concurrency/rate/partition state; ResourceGovernor/pre-admission ownership remains independent. Exact-head PR Quick 32692486306 is green, including Unit 1134/1134 and Integration 394/394.
This was referenced Aug 24, 2026
SunSi12138
added a commit
that referenced
this pull request
Aug 25, 2026
This was referenced Aug 25, 2026
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #329 as a stacked change on #328.
Stack base (latest reviewed #328 exact head):
21a3ebef8e05b97dffd49cc13c5cf1209153d657Base branch:
issue-324-admission-state-kernelFinal implementation head:
c1c68580e3337bf640c5c677cce829cae592f423Scope:
This PR intentionally does not add enabled-to-enabled policy updates, resize/migration APIs, dynamic module redesign, Hosting/IOptionsMonitor integration, or ResourceGovernor changes.
#329 DoD / test matrix
Covered by deterministic unit/integration tests and the existing regression suite:
Lifecycle tests assert terminal stable-kernel diagnostics return to zero where applicable:
LiveProgramCount=0,RetiredProgramCount=0,RuleStateCount=0,PartitionStateCount=0,QueuedCalls=0,QueuedBytes=0,ActivePermits=0.Exact-head GitHub Actions evidence
PR Quick run:
32692486306— success.PR head:
c1c68580e3337bf640c5c677cce829cae592f423.Actions checkout merge:
b07fe7cf1686815834c1386535d662c4391805e0= final PR head merged onto fixed stacked base21a3ebef8e05b97dffd49cc13c5cf1209153d657.All execution and testing for this implementation was performed through GitHub Actions as requested.
Ready for review. Do not merge automatically; this PR remains stacked on #328.