feat(server): capture admission program generation per request - #323
Merged
Merged
Conversation
This was referenced Aug 23, 2026
SunSi12138
added a commit
that referenced
this pull request
Aug 25, 2026
This was referenced Aug 25, 2026
32 tasks
SunSi12138
added a commit
that referenced
this pull request
Aug 26, 2026
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implements #322 as the stacked follow-up to #319, now restacked directly onto
devafter the lower stack landed.This PR remains limited to immutable Dynamic Admission program publication/capture and per-request generation lifetime. It does not add a runtime mutation API, migrate limiter state, or redesign ResourceGovernor/decode/pre-admission-stream ownership.
Implementation
AdmissionProgramgeneration; disabled remains a no-controller publication;RequestLoop;ServerCallCancellationStatewhen admission state is created and releasing it exactly once from terminal cleanup;Validation
Final exact head:
ada8dde71b58a480b7b843cea638f1e0d43cc1aaPR Quick:
32993893194, attempt 2 — passed on the exact branch head.CodeQL:
32993806558— passed on the same exact head.The first PR Quick attempt exposed and led to fixes for two restack-only test harness compatibility issues. A subsequent isolated shared-memory control-channel test failure did not reproduce on failed-job rerun; the complete attempt-2 quick job and all rerun codec jobs passed.
Residual risk
No known correctness or CI blocker remains for this slice. Runtime Admission mutation/state migration remains intentionally out of scope for later #264 slices.
Refs #322, #319, #273, #264.