Bump vLLM version for DSV4 B200 disagg#1899
Conversation
Bump the DeepSeek-V4-Pro B200 disaggregated low-latency vLLM recipe (disagg-b200-low-latency.yaml) from vllm/vllm-openai:v0.20.1 to v0.23.0.
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢
PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
1 similar comment
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢
PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
Align the nvidia-master.yaml image with the recipes' v0.23.0 container so the registered srt-slurm alias resolves to the new image, and add the perf-changelog entry that triggers the sweep.
…vllm-image-bump # Conflicts: # perf-changelog.yaml
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28078051095 |
2 similar comments
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28078051095 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28078051095 |
|
/reuse-sweep-run |
|
hi @RohitNagraj can u ask an NVIDIA CODEOWNER like @Ankur-singh for an PR review https://github.com/SemiAnalysisAI/InferenceX/blob/main/docs/PR_REVIEW_CHECKLIST.md |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:This is a dis-agg config Signed: |
|
@Ankur-singh BLOCKED — Check 3 fails: no recipe link in the sign-off's "Additional detail section" (only "This is a dis-agg config"). A link to a vLLM-recipes/SGLang-cookbook PR or published page is required by the merge standard; please add one (or the upstream commit this is mirrored from) and re-sign.
|
|
/reuse-sweep-run |
1 similar comment
|
/reuse-sweep-run |
Bumps the DeepSeek-V4-Pro B200 disaggregated low-latency vLLM recipe (
disagg-b200-low-latency.yaml) fromvllm/vllm-openai:v0.20.1tov0.23.0.Recreated from #1898 on a branch in this repository. Supersedes and closes #1898.
Note
Medium Risk
Config-only, but a multi-minor vLLM image bump on a complex disagg B200 benchmark can change runtime behavior and compatibility with the pinned Dynamo wheel until the job is revalidated.
Overview
Updates the DeepSeek-V4-Pro B200 disaggregated low-latency Slurm recipe (
disagg-b200-low-latency.yaml) to run on vLLM 0.23.0 instead of 0.20.x.model.containerandidentity.container.imagenow usevllm/vllm-openai:v0.23.0, andidentity.frameworks.vllmis set to0.23.0so launch metadata matches the container. Dynamo wheel and all vLLM/serving flags are unchanged.Reviewed by Cursor Bugbot for commit bb6fef2. Bugbot is set up for automated code reviews on this repo. Configure here.