Bump vLLM version for DSV4 B200 disagg#1898
Closed
hjjq wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e821fa1. Configure here.
| model: | ||
| path: "deepseek-v4-pro" | ||
| container: "vllm/vllm-openai:v0.20.1" | ||
| container: "vllm/vllm-openai:v0.23.0" |
There was a problem hiding this comment.
Recipe image master mismatch
Medium Severity
This bump sets model.container and identity.container.image to vllm/vllm-openai:v0.23.0, but dsv4-fp4-b200-dynamo-vllm in nvidia-master.yaml still uses vllm/vllm-openai:v0.20.1. Those fields are meant to match, so sweep metadata and launcher container aliases can disagree with the image srtctl pulls from the recipe.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e821fa1. Configure here.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Config-only version bump in a single benchmark recipe; main risk is benchmark/runtime compatibility with the pinned Dynamo wheel, not application code paths.
Overview
Updates the DeepSeek V4 B200 disaggregated low-latency Slurm recipe (
disagg-b200-low-latency.yaml) from vLLM v0.20.1 / 0.20.0 to v0.23.0.The bump is applied consistently on
model.container,identity.container.image, andidentity.frameworks.vllmso the launched container and recorded benchmark identity match the new stack. No changes to Dynamo wheel, vLLM CLI flags, Slurm layout, or benchmark parameters.Reviewed by Cursor Bugbot for commit e821fa1. Bugbot is set up for automated code reviews on this repo. Configure here.