[Klaud Cold] minimaxm3-fp8-mi355x-vllm-mtp: run with CUDA graphs (drop --enforce-eager)#1755
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27491156713 |
| --max-model-len "$MAX_MODEL_LEN" \ | ||
| --kv-cache-dtype fp8 \ | ||
| --attention-backend TRITON_ATTN \ | ||
| --enforce-eager \ |
There was a problem hiding this comment.
Missing MTP cudagraph capture sizing
Medium Severity
The EAGLE3 MTP recipe now runs with CUDA graphs but never passes --max-cudagraph-capture-size, while other MiniMax MTP scripts size capture to CONC * (1 + speculative tokens). Sweeps up to hundreds of concurrent requests can decode outside the captured graph sizes, so results may not reflect the intended full-graph speedup.
Reviewed by Cursor Bugbot for commit 234abd2. Configure here.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27491157475 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 528c410. Configure here.
| --max-model-len "$MAX_MODEL_LEN" \ | ||
| --kv-cache-dtype fp8 \ | ||
| --attention-backend TRITON_ATTN \ | ||
| --enforce-eager \ |
There was a problem hiding this comment.
Missing cudagraph capture sizing
Medium Severity
Removing --enforce-eager turns on CUDA graphs, but neither script sets --max-cudagraph-capture-size or the CAPTURE_SIZE logic used on the MiniMax B200/B300 recipes. vLLM’s default capture list caps around 512, while these sweeps hit concurrency 512–1024 (MTP needs scaling by speculative tokens per step), so many jobs won’t run under full graph capture and the intended cudagraph speedup won’t be measured reliably.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 528c410. Configure here.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27491231421 |
528c410 to
2899dc8
Compare
…ager) MTP-only: drop --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add --no-enable-prefix-caching on the MI355X EAGLE3 MTP recipe. The non-MTP MI355X recipe already got this via #1754, so this PR no longer touches it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2899dc8 to
1e98162
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27506102313 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27506287453 |
|
/reuse-sweep-run |


Summary
Runs the MiniMax-M3 MXFP8 MI355X recipes with CUDA graphs instead of eager execution, to measure the cudagraph speedup. Touches both the non-MTP and EAGLE3 MTP scripts:
--enforce-eagerfrom thevllm serveline inminimaxm3_fp8_mi355x.shandminimaxm3_fp8_mi355x_mtp.sh.export VLLM_USE_BREAKABLE_CUDAGRAPH=0to both — this avoids the M3-decode breakable-cudagraph path that previously forced eager execution (the reason--enforce-eagerwas originally set).Everything else is unchanged (block-size 128,
--language-model-only, FP8 KV cache, TRITON_ATTN, minimax_m3 parsers; MTP keeps the EAGLE3 draft + the in-placeamd/model.pypatch).Config keys re-swept:
minimaxm3-fp8-mi355x-vllm,minimaxm3-fp8-mi355x-vllm-mtp(perf-changelog entry added so the sweep picks both up).Validation
bash -npasses on both scripts; serve-line--enforce-eagerremoved (only comments mention it);VLLM_USE_BREAKABLE_CUDAGRAPH=0exported in both.🤖 Generated with Claude Code
Note
Low Risk
Benchmark-only launch script and changelog; no application runtime or security-sensitive logic.
Overview
Updates the MiniMax-M3 MXFP8 MI355X EAGLE3 MTP fixed-sequence vLLM recipe so throughput reflects CUDA graph execution instead of eager mode.
The
vllm serveinvocation drops--enforce-eagerand the script exportsVLLM_USE_BREAKABLE_CUDAGRAPH=0, sidestepping the M3 decode breakable-cudagraph path that previously required eager (aligned with the non-MTP MI355X change in #1754). It also passes--no-enable-prefix-caching, consistent with other random-prompt MiniMax MI355X recipes.perf-changelog.yamladds an entry forminimaxm3-fp8-mi355x-vllm-mtpso the sweep re-runs this config key.Reviewed by Cursor Bugbot for commit 1e98162. Bugbot is set up for automated code reviews on this repo. Configure here.
Update: also adds
--no-enable-prefix-cachingto both MI355X scripts (matching the MI300X recipes).