Skip to content

[AMD] perf: enable MiniMax M3 CUDA graphs on MI355X#1754

Merged
cquil11 merged 3 commits into
mainfrom
codex/minimaxm3-mi355x-cudagraph
Jun 14, 2026
Merged

[AMD] perf: enable MiniMax M3 CUDA graphs on MI355X#1754
cquil11 merged 3 commits into
mainfrom
codex/minimaxm3-mi355x-cudagraph

Conversation

@cquil11

@cquil11 cquil11 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Remove --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, and disable prefix caching for the non-MTP MI355X recipe.

Validation: shell syntax and MI355X sweep generation.


Note

Low Risk
Benchmark-only launch flags for a single AMD recipe; no auth, serving API, or shared runtime code changes.

Overview
Aligns the MiniMax-M3 MXFP8 MI355X non-MTP vLLM recipe with the recent MI300X CUDA-graph change (#1750).

The benchmark script now exports VLLM_USE_BREAKABLE_CUDAGRAPH=0, drops --enforce-eager so CUDA graphs can run, and passes --no-enable-prefix-caching on vllm serve (consistent with other MiniMax random-dataset sweeps). perf-changelog.yaml documents the update for minimaxm3-fp8-mi355x-vllm.

Reviewed by Cursor Bugbot for commit 26bbb94. Bugbot is set up for automated code reviews on this repo. Configure here.

@cquil11 cquil11 requested a review from a team June 14, 2026 06:47
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@cquil11

cquil11 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run

@cquil11 cquil11 merged commit 03caeb3 into main Jun 14, 2026
4 of 6 checks passed
@cquil11 cquil11 deleted the codex/minimaxm3-mi355x-cudagraph branch June 14, 2026 13:15
@github-actions

Copy link
Copy Markdown
Contributor

functionstackx added a commit that referenced this pull request Jun 14, 2026
Rebased onto main. The non-MTP MI355X cudagraph change already landed via
#1754, so the net change here is the EAGLE3 MTP recipe: drop
--enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add
--no-enable-prefix-caching (plus a clarifying comment on the non-MTP
script). Re-sweeps minimaxm3-fp8-mi355x-vllm and -vllm-mtp.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Jun 14, 2026
…ager)

MTP-only: drop --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add
--no-enable-prefix-caching on the MI355X EAGLE3 MTP recipe. The non-MTP
MI355X recipe already got this via #1754, so this PR no longer touches it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Jun 14, 2026
…ager) (#1755)

MTP-only: drop --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add
--no-enable-prefix-caching on the MI355X EAGLE3 MTP recipe. The non-MTP
MI355X recipe already got this via #1754, so this PR no longer touches it.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant