[AMD] perf: enable MiniMax M3 CUDA graphs on MI355X#1754
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27491077319 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27491077523 |
|
/reuse-sweep-run |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27500023263 |
Rebased onto main. The non-MTP MI355X cudagraph change already landed via #1754, so the net change here is the EAGLE3 MTP recipe: drop --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add --no-enable-prefix-caching (plus a clarifying comment on the non-MTP script). Re-sweeps minimaxm3-fp8-mi355x-vllm and -vllm-mtp. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ager) MTP-only: drop --enforce-eager, set VLLM_USE_BREAKABLE_CUDAGRAPH=0, add --no-enable-prefix-caching on the MI355X EAGLE3 MTP recipe. The non-MTP MI355X recipe already got this via #1754, so this PR no longer touches it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Remove
--enforce-eager, setVLLM_USE_BREAKABLE_CUDAGRAPH=0, and disable prefix caching for the non-MTP MI355X recipe.Validation: shell syntax and MI355X sweep generation.
Note
Low Risk
Benchmark-only launch flags for a single AMD recipe; no auth, serving API, or shared runtime code changes.
Overview
Aligns the MiniMax-M3 MXFP8 MI355X non-MTP vLLM recipe with the recent MI300X CUDA-graph change (#1750).
The benchmark script now exports
VLLM_USE_BREAKABLE_CUDAGRAPH=0, drops--enforce-eagerso CUDA graphs can run, and passes--no-enable-prefix-cachingonvllm serve(consistent with other MiniMax random-dataset sweeps).perf-changelog.yamldocuments the update forminimaxm3-fp8-mi355x-vllm.Reviewed by Cursor Bugbot for commit 26bbb94. Bugbot is set up for automated code reviews on this repo. Configure here.