ipscan@3.9.2: Switch to JRE self-contained installer, drop 32-bit support

[SorYoshino]

Description

This PR updates the ipscan manifest to align with upstream changes and improve user experience.

Changes

• Removed 32-bit architecture support
  • Upstream discontinued 32-bit builds after version 3.8.2.
• Switched the download source to the Windows installer (ipscan-<version>-setup.exe)
• Updated metadata
  • Revised description and homepage so that users can correctly find Angry IP Scanner on scoop.sh.
  • Added a proper license object with URL.
  • Simplified pre_install cleanup logic.
  • Replaced outdated notes with guidance on plugin installation and links to the official FAQ.

Reasoning

The Windows installer is now the officially recommended distribution method by the upstream project, as it includes a bundled JRE and ensures the most reliable execution environment.

Additionally, improving the manifest’s metadata allows users to locate Angry IP Scanner more easily on the Scoop website, reducing redundant package request issues.

This update removes obsolete architecture handling and simplifies future maintenance.

Testing

┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket][ angry-ip-scanner ≢]
└─>  scoop install .\ipscan.json
Installing 'ipscan' (3.9.2) [64bit] from 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket\ipscan.json'
Loading ipscan-3.9.2-setup.exe from cache.
Checking hash of ipscan-3.9.2-setup.exe ... ok.
Extracting ipscan-3.9.2-setup.exe ... done.
Running pre_install script...done.
Linking D:\Software\Scoop\Local\apps\ipscan\current => D:\Software\Scoop\Local\apps\ipscan\3.9.2
Creating shim for 'ipscan'.
Making D:\Software\Scoop\Local\shims\ipscan.exe a GUI binary.
Creating shortcut for Angry IP Scanner (ipscan.exe)
'ipscan' (3.9.2) was installed successfully!
Notes
-----
To install a plugin, place the .jar file in "$HOME\.ipscan" and restart the application.
For more information, see: https://angryip.org/contribute/plugins
For common issues and troubleshooting, visit: https://angryip.org/faq

┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket][ angry-ip-scanner ≢]
└─> Get-ChildItem -Path "D:\Software\Scoop\Local\apps\ipscan\current" 

        Directory: D:\Software\Scoop\Local\apps\ipscan\current


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d----        2025/10/16     19:06                  jre
-a---         2025/8/19      5:09         114517   icon.ico
-a---        2025/10/16     19:06            161   install.json
-a---         2025/8/19      5:09        2917973 󰣆  ipscan.exe
-a---         2025/8/19      5:09          18344 󰈙  license.txt
-a---        2025/10/16     19:06           1410   manifest.json

• Closes [Bug]: ipscan no longer supports the 32-bit architecture #16348
• Relates to 6ad59e5

• Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
• I have read the Contributing Guide

Summary by CodeRabbit

• Documentation
  • Updated product name and homepage to HTTPS; installation notes revised and plugin installation guidance added; license now includes a reference link.
• Changes
  • 64-bit distribution removed; 32-bit distribution retained.
  • Installer now removes prior installation files during setup.
  • Runtime recommendation removed and replaced by plugin guidance.

[coderabbitai]

Walkthrough

Updated bucket/ipscan.json: description and homepage changed; license converted from string to object with identifier and url; 64‑bit architecture and its autoupdate entry removed; 32‑bit architecture retained; pre_install moved to top-level; notes and suggest adjusted/removed.

Changes

Cohort / File(s)	Summary
ipscan package manifest bucket/ipscan.json	Description and homepage updated; license converted from a string to an object with identifier and url; notes revised and suggest block removed; top-level pre_install added (moved from architecture/32bit); architecture/64bit and its autoupdate entry removed; architecture/32bit retained and autoupdate preserved.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hop through manifests, tidy and spry,

64-bit folded with a careful sigh,
32-bit kept with a cleaner tune,
License boxed under a quiet moon,
A rabbit’s nibble — small change, neat and spry.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues Check	❓ Inconclusive	The PR claims to meet the key objectives from issue #16348: switching to the Windows installer (which bundles JRE) and removing 32-bit build support. The raw_summary confirms the download source was switched and shows the 64bit architecture block was removed. However, the raw_summary indicates the 32bit architecture block was "retained with updated pre_install command," which creates ambiguity about whether true 32-bit build support was completely eliminated or if the entry now points to the universal installer for both architectures. The summary does not explicitly clarify whether the 32bit entry's URL/hash were changed or removed, making it unclear if the objective to "completely remove the 32-bit build from the manifest" was fully achieved.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "ipscan@3.9.2: Switch to JRE self-contained installer, drop 32-bit support" clearly and specifically summarizes the main changes in the changeset. It follows the conventional format with the package name and version, and directly addresses the two primary modifications: switching to the Windows installer (which bundles JRE) and dropping 32-bit architecture support. The title is concise, readable, and gives developers scanning the history a clear understanding of the primary intent without being vague or misleading.
Out of Scope Changes Check	✅ Passed	The changes in the PR appear to be appropriately scoped to the objectives from issue #16348. Modifications to metadata (description, homepage, license format) directly support improved discoverability on scoop.sh as mentioned in the PR reasoning. Updates to the pre_install cleanup logic and notes align with transitioning to the Windows installer approach. The removal of the suggest block and architecture-specific handling logically follows from standardizing on the universal installer distribution. No changes appear to introduce functionality or modifications unrelated to the stated objectives of updating the manifest for the new installer-based distribution.
Description Check	✅ Passed	The PR description comprehensively follows the repository template requirements. It includes a general summary, explicit reference to the linked issue (#16348), demonstration of having read the contributing guide (both checkboxes are marked), and uses the conventional PR title format. The description goes beyond basic requirements by providing detailed sections on changes, reasoning for those changes, and actual testing results showing successful installation. All required elements are present and properly completed.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8442080 and 420ef34.

📒 Files selected for processing (1)

• bucket/ipscan.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• bucket/ipscan.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: WindowsPowerShell

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

All changes look good.

Wait for review from human collaborators.

ipscan

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

bucket/ipscan.json (2)

3-8: Metadata updates LGTM; switch homepage to HTTPS (optional).

Good description and license object. Recommend HTTPS for homepage; optionally use the raw LICENSE URL.

-    "homepage": "http://angryip.org",
+    "homepage": "https://angryip.org",
@@
-        "url": "https://github.com/angryip/ipscan/blob/master/LICENSE"
+        "url": "https://raw.githubusercontent.com/angryip/ipscan/master/LICENSE"

---

10-12: Notes improved; add a hint to create the folder if missing (optional).

Clarifies plugins and FAQ well. Consider mentioning the folder may need to be created.

-        "To install a plugin, place the .jar file in \"$HOME\\.ipscan\" and restart the application.",
+        "To install a plugin, place the .jar file in \"$HOME\\.ipscan\" (create it if it doesn't exist) and restart the application.",

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a56df9b and 4081c56.

📒 Files selected for processing (1)

• bucket/ipscan.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: WindowsPowerShell

🔇 Additional comments (1)

bucket/ipscan.json (1)

18-18: pre_install cleanup LGTM.

Pattern covers $-prefixed extraction artifacts and uninstall files; safe with SilentlyContinue.

[SorYoshino]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

ipscan

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[z-Fng]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

ipscan

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[z-Fng]

Thanks!