[Fix] GHCR deployment acceptance fails with unauthorized image pulls - #121
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
[Fix] GHCR deployment acceptance fails with unauthorized image pulls#121roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Deployment acceptance now authenticates to GHCR with the same
docker/login-action+GITHUB_TOKENpattern already used by the image build and publish jobs, beforepnpm deployment:smokepulls the previousdevelop/ channel baseline tags (includingroomote-web:develop).Also unblocked push-time
lint:fast/ knip by making a worker automation-tool type local only; that unused-export warning was already ondevelopafter #116 and was failing pre-push independently of the GHCR fix.Why this change was made
After #106 added prior-channel upgrade validation, the Deployment acceptance job withdrew GHCR images with
packages:readbut never ran docker login. CI then failed with:Head "https://ghcr.io/v2/roocodeinc/roomote-web/manifests/develop": unauthorizedPermissions alone do not authenticate the Docker client for private packages.
Impact
Publish GHCR Images on
developcan re-run baseline pulls during deployment acceptance instead of failing before build/publish, restoring the gated multi-arch publish path. No product UI or user-facing runtime behavior changes.