[Chore] Validate deployment artifacts in CI - #106
Merged
Conversation
Contributor
|
Re-checked after the latest push. The only new PR-scoped change since the last review is the Fly deployment validation simplification: it collapses the redundant
|
Contributor
Author
|
Addressed the review nit in 30a9a95: the Fly process validation now uses one shared assertion for every runtime service. Re-ran |
mrubens
force-pushed
the
codex/deployment-artifacts-ci
branch
2 times, most recently
from
July 10, 2026 17:44
089fb42 to
3715679
Compare
mrubens
force-pushed
the
codex/deployment-artifacts-ci
branch
from
July 10, 2026 17:52
3715679 to
e1ad599
Compare
mrubens
pushed a commit
that referenced
this pull request
Jul 10, 2026
…worker Publish two images again instead of eight. Every control-plane service runs from the shared runtime-app target; the container command and ROOMOTE_SERVICE select the service and its env contract. The Compose hardening from #105 (read-only filesystems, dropped capabilities, per-service env contracts, controller-only Docker socket proxy) and the deployment validation from #106 stay in place, adapted to the two-image world. Also authenticate to GHCR in the deployment-acceptance job so baseline pulls cannot fail on package visibility, which is what has blocked every publish since #106 landed: the six new per-service packages defaulted to private and the smoke test pulled them anonymously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Deployment artifacts were not first-class CI inputs, so
docker compose up --waitcould succeed while the execution plane was unhealthy and release-only deployment paths could drift unnoticed.Validation
pnpm deployment:validatepnpm --filter @roomote/cloud-agents check-typespnpm --filter @roomote/cloud-agents lintpnpm knippnpm lint:fast,pnpm check-types:fast, andpnpm knipdevelopimage → candidate migration → rollback → candidateCompatibility note
v0.0.1predates the current rewritten Drizzle migration baseline and cannot be used as a direct migration predecessor. For the first gated tagged release, CI tests the prior publishedmaincandidate. Subsequent tagged releases use the immediately preceding immutable release tag.