[Improve] Microsoft Teams setup flow (port of OpenRoomote #550) - #12
Merged
Conversation
* Add Teams setup redirect guidance * Fix onboarding frame scrolling * Make Teams reconnect message more human * Send Teams chat images as attachments * Require Teams bot fields during setup * ui * setup ui * feat(setup): offer downloadable Teams app package in the setup flow * feat(setup): simplify Teams bot credential entry * feat(setup): require shared Teams app credentials * refactor(setup): split provider setup experiences * chore(web): remove stale comms provider import * chore(setup): keep provider setup props local * feat(setup): clarify Microsoft Teams setup steps * copy * feat(setup): refine Teams app setup flow * test(web): mock tooltip in comms settings tests --------- Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
|
Re-reviewed the latest fix commit. Both earlier findings are resolved and I found no new code issues. See task
|
Contributor
|
Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below. I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Contributor
Author
|
@openmote can you fix the issues? |
|
I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task |
…ters Keep original Bot Framework attachments when a later footer-bearing Teams reply rewrites the previous message, and remove a stray partial Tailwind class from provider setup URL styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Port of https://github.com/RooCodeInc/OpenRoomote/pull/550 with follow-up review fixes:
Why this change was made
The Teams setup port makes self-hosted Microsoft Teams configuration easier and more reliable. Review found that moving outbound Teams images from markdown into Bot Framework attachments meant re-editing an earlier footer-bearing reply would drop those attachments, and a leftover partial
text-class needed cleanup.Impact
Operators get a clearer single-app Teams setup path with a generated app package. Teams thread replies that include image artifacts keep those images when Roomote relocates the managed footer to a newer reply.
Port notes
teams-app-icon-outline.pngasset.providerSetupCopy.test.tswas renamed toproviderSetupCopy.client.test.ts, matching this repo's client-test convention..agent-guidance/features/web-dashboard.mdauto-merged so this repo's xAI provider mention (from [Feat] Add xAI as an inference provider and Grok 4.5 to recommended models #11) is preserved alongside the new Teams paragraph; the ADO PAT copy from [Improve] Bring the Azure DevOps source-control settings section to parity #9 is also untouched.