Skip to content

[Improve] Microsoft Teams setup flow (port of OpenRoomote #550) - #12

Merged
mrubens merged 2 commits into
developfrom
port/teams-setup-flow-550
Jul 8, 2026
Merged

[Improve] Microsoft Teams setup flow (port of OpenRoomote #550)#12
mrubens merged 2 commits into
developfrom
port/teams-setup-flow-550

Conversation

@mrubens

@mrubens mrubens commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What changed

Port of https://github.com/RooCodeInc/OpenRoomote/pull/550 with follow-up review fixes:

  • add a downloadable, generated Microsoft Teams app package to setup and settings
  • simplify Teams setup around a single Entra app whose credentials also power the bot
  • refactor provider setup UI so Microsoft can own its multi-step instructions
  • reorder Teams setup so app values and package upload happen before bot capability configuration
  • keep original Teams image attachments when a later footer-bearing reply clears the previous footer
  • remove a stray incomplete Tailwind class from provider setup URL styling

Why this change was made

The Teams setup port makes self-hosted Microsoft Teams configuration easier and more reliable. Review found that moving outbound Teams images from markdown into Bot Framework attachments meant re-editing an earlier footer-bearing reply would drop those attachments, and a leftover partial text- class needed cleanup.

Impact

Operators get a clearer single-app Teams setup path with a generated app package. Teams thread replies that include image artifacts keep those images when Roomote relocates the managed footer to a newer reply.

Port notes

* Add Teams setup redirect guidance

* Fix onboarding frame scrolling

* Make Teams reconnect message more human

* Send Teams chat images as attachments

* Require Teams bot fields during setup

* ui

* setup ui

* feat(setup): offer downloadable Teams app package in the setup flow

* feat(setup): simplify Teams bot credential entry

* feat(setup): require shared Teams app credentials

* refactor(setup): split provider setup experiences

* chore(web): remove stale comms provider import

* chore(setup): keep provider setup props local

* feat(setup): clarify Microsoft Teams setup steps

* copy

* feat(setup): refine Teams app setup flow

* test(web): mock tooltip in comms settings tests

---------

Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
@roomote-roomote-v1

roomote-roomote-v1 Bot commented Jul 8, 2026

Copy link
Copy Markdown

Re-reviewed the latest fix commit. Both earlier findings are resolved and I found no new code issues. See task

  • Teams replies with images can lose those images when a later footer-bearing reply clears the footerapps/api/src/handlers/mcp/communication-thread-replies.ts:144. Fixed: footer images now flow through ThreadReplyFooterRecord.images, clearPreviousFooter re-sends previousFooterRecord.images, and TeamsCommunicationProvider.updateMessageupdateActivity re-attaches them as Bot Framework attachments (packages/communication/src/teams-provider.ts:211, packages/communication/src/teams-bot-framework-client.ts:325). Covered by new tests across the API handler, provider, and footer-state layers.
  • Incomplete Tailwind class text-apps/web/src/app/(onboarding)/setup/ProviderSetupInstructions.tsx:48. Fixed: the stray text- was removed, leaving font-mono text-xs text-foreground truncate.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (mrubens)[https://github.com/mrubens]
@brunobergher
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mrubens

mrubens commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@openmote can you fix the issues?

@roomote-roomote-v1

Copy link
Copy Markdown

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-roomote-v1

roomote-roomote-v1 Bot commented Jul 8, 2026

Copy link
Copy Markdown

Fixed both review findings in 7ed3bf8. See task

  • Teams footer clear now re-attaches the original Bot Framework image attachments instead of sending a text-only rewrite
  • Removed the incomplete text- Tailwind class in provider setup instructions

Commit: 7ed3bf8
Revert

…ters

Keep original Bot Framework attachments when a later footer-bearing Teams
reply rewrites the previous message, and remove a stray partial Tailwind
class from provider setup URL styling.
@mrubens
mrubens merged commit 41076e1 into develop Jul 8, 2026
@mrubens
mrubens deleted the port/teams-setup-flow-550 branch July 12, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants