Recover stalled worker bootstraps promptly - #550
Merged
Conversation
Contributor
|
No new code issues found. See task
Reviewed c3186df |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Detached worker processes could exit after the provider launch call had already returned successfully. The exit was visible in controller logs, but it was not connected to task lifecycle state, leaving affected runs presented as booting until orphan recovery.
Impact
Transient startup connectivity gets one fresh network path without allowing an unbounded restart loop. A replacement that also fails becomes visible promptly, and the existing long orphan-recovery timeout remains as a final safety net for broader provisioning failures.
Validation
pnpm --filter @roomote/compute-providers check-typespnpm --filter @roomote/controller check-typespnpm --filter @roomote/types check-typespnpm --filter @roomote/sdk check-typespnpm --filter @roomote/compute-providers lintpnpm --filter @roomote/controller lint