Skip to content

Add addAnyHandler().#41

Merged
inamiy merged 3 commits into
swift/2.0from
addAnyHandler
Feb 24, 2016
Merged

Add addAnyHandler().#41
inamiy merged 3 commits into
swift/2.0from
addAnyHandler

Conversation

@inamiy
Copy link
Copy Markdown
Member

@inamiy inamiy commented Feb 22, 2016

This pull request is a new feature for #40 to support addAnyHandler()
which works for both event-based & state-based transitions.

See test case: StateMachineEventTests.swift#L382-L446

@inamiy inamiy mentioned this pull request Feb 22, 2016
@inamiy inamiy added this to the 4.1.0 milestone Feb 22, 2016
@sluramod
Copy link
Copy Markdown

I expected transition to be input parameter of the method, and the handler called only when the transition happened, but regardless of how.

@inamiy
Copy link
Copy Markdown
Member Author

inamiy commented Feb 23, 2016

@sluramod
Thanks for feedback!
That sounds even better, and I updated code in 1e88704.
Please see updated test case.

@sluramod
Copy link
Copy Markdown

excellent, thank you.

@inamiy
Copy link
Copy Markdown
Member Author

inamiy commented Feb 24, 2016

Ready to :shipit:

inamiy added a commit that referenced this pull request Feb 24, 2016
@inamiy inamiy merged commit be66947 into swift/2.0 Feb 24, 2016
@inamiy inamiy deleted the addAnyHandler branch February 24, 2016 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants