Fix AOT pipe operator parity — AssertOptionsRuntime LLVM CFG (#9750) - #9854
Merged
Merged
Conversation
…CFG (#9750). Emit literalEmptyString inside the empty-callback basic block so LLVM verification passes, unblocking all AOT compiles; re-enable pipe_operator AOT fixture. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssertOptionsRuntime::implementCallbackOption()—literalEmptyString()was emitted after a branch terminator onaopt_cb_store_*, causing module verification failure that blocked all AOT compiles.pipe_operatorAOT fixture; adjust concat-on-LHS line to"ab" |> strtoupper(...)(concat-in-call AOT bug is separate; VM/JIT compliance still covers"a" . "b" |> fprecedence).Closes #9750
php-src reference
Zend/zend_compile.c— desugared vialib/Ast/PipeOperatorDesugar.php(unchanged)lib/JIT/Builtin/AssertOptionsRuntime.php(php-in-php: JIT AssertOptionsRuntime — route assert_options() through VmAssert PHP not ~476-line LLVM (#1492) #9513 helper path)Verification
Output:
Test plan
"hello" |> strtoupper(...)on VM, JIT, AOTpipe_operatormatrix (5/5)pipe_operator.phpt(1/1)AssertOptionsRuntimeStandaloneTestLLVM module verifyMade with Cursor