php-in-php: JIT AssertOptionsRuntime — route assert_options() through VmAssert PHP not ~476-line LLVM (#1492)

[PurHur]

Category

php-in-php · php-src-strict runtime semantics via PHP SSOT

Problem

assert_options() JIT lowering lives in lib/JIT/Builtin/AssertOptionsRuntime.php (~476 LLVM lines) plus AssertIniRuntime.php globals (~88 lines). The VM already has PHP handlers in ext/standard/ (see assert_options.php, assert.php, issue #3316).

JIT/AOT should call the same PHP implementation through a thin JIT helper bridge (pattern: LastErrorRuntime → VmErrorLast, IniRuntime → VmIni), not duplicate assert INI state in LLVM globals.

php-src reference

• php/php-src ext/standard/assert.c — PHP_FUNCTION(assert_options), zend_assertions INI
• php/php-src Zend/zend_API.c — assertion callback storage

Repro (parity baseline — VM must stay green)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php -r "
var_dump(assert_options(ASSERT_ACTIVE));
assert_options(ASSERT_ACTIVE, 1);
var_dump(assert_options(ASSERT_ACTIVE));
"'

JIT gap today: compiling assert_options() in a JIT unit uses LLVM AssertOptionsRuntime instead of PHP.

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/jit.php -r "var_dump(assert_options(ASSERT_ACTIVE));"'

Scope (this repo)

Path	Work
ext/standard/VmAssert.php (or extend existing assert VM class)	SSOT for assert_options get/set
lib/JIT/Builtin/AssertOptionsRuntime.php	Replace LLVM bodies with JitHelper call into PHP
lib/JIT/Builtin/AssertIniRuntime.php	Delete or shrink to thin ABI; INI state owned by PHP
lib/JIT/BuiltinRegistry.php	Wire helper registration
Tests	JIT PHPT for assert_options round-trip

Done when

• JIT/AOT assert_options() delegates to PHP SSOT — delete or substantially shrink AssertOptionsRuntime LLVM (target: thin trampoline only)
• VM repro unchanged (php-src-strict)
• assert_options(ASSERT_CALLBACK, $fn) callback identity preserved across JIT calls
• PR body notes lines removed from AssertOptionsRuntime.php / AssertIniRuntime.php
• No new logic in runtime/*.c

Related

• Stdlib: assert() — runtime assertion builtin with INI and zend.assertions (ext/standard/assert.c parity) #3316 assert() parity · php-in-php: JIT DefineRuntime — route define()/defined() through Vm Context PHP not LLVM hashtable (#1492) #9410 DefineRuntime PHP-in-PHP pattern · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — starting this run.

[PurHur]

Merged via #9808.

PHP SSOT: ext/standard/AssertOptionsJitHelper.php — VM (VmAssertState) and JIT/AOT share the same assert INI/options state.

LLVM removed: phpc_assert_* globals + malloc callback storage in AssertOptionsRuntime; AssertIniRuntime is now ABI declarations only (__phpc_assert_* bridges).

Verification (all green):

• php vendor/bin/phpunit test/unit/AssertOptionsRuntimeShrinkTest.php test/unit/JIT/AssertOptionsRuntimeStandaloneTest.php --group aot-lint
• php vendor/bin/phpunit --filter assert_options test/compliance/JITTest.php
• VM/JIT assert_options(ASSERT_ACTIVE) repro
• make bootstrap-selfhost-vm-driver-execute-probe